-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Despite minifyCss set to false, inlined styles gets modified #798
Comments
Sounds reasonable - PR is welcomed. |
This creates integration issues with react server-sider rendering. Right now, I'm only observing those issues in Firefox. The markup is reusable in Chrome + Safari.
I guess those trailing semicolons do matter. |
@petermikitsh Have this issue in Chrome as well. Unclear how to configure html-minifier to leave trailing semicolon alone in the style attribute, @alexlamsl is the referenced issue a proposed fix? |
I have created a fork (found here: https://github.com/DChristiany/html-minifier), that offers a configuration option, that does not remove trailing semicolons. |
When minifying this with
minifyCss: false
:The output is changed and the last
;
in the inline style gets removed leading to reconciliation errors in React. While removing the last;
is a neat feature, when theminifyCss
isfalse
, the inline style should not be altered.Referenced errors:
The text was updated successfully, but these errors were encountered: