Skip to content

Commit 8ce971d

Browse files
committed
Review comments.
1 parent 3c0f873 commit 8ce971d

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

rls/src/main/java/io/grpc/rls/CachingRlsLbClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ private CachedRouteLookupResponse asyncRlsCall(
307307
}
308308
final SettableFuture<RouteLookupResponse> response = SettableFuture.create();
309309
io.grpc.lookup.v1.RouteLookupRequest routeLookupRequest = REQUEST_CONVERTER.convert(
310-
requestFactory.create(routeLookupRequestKey, routeLookupReason));
310+
RouteLookupRequest.create(routeLookupRequestKey.keyMap(), routeLookupReason));
311311
logger.log(ChannelLogLevel.DEBUG,
312312
"[RLS Entry {0}] Starting RouteLookup: {1}", routeLookupRequestKey, routeLookupRequest);
313313
rlsStub.withDeadlineAfter(callTimeoutNanos, TimeUnit.NANOSECONDS)

rls/src/main/java/io/grpc/rls/RlsProtoData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,14 @@ static RouteLookupRequestKey create(ImmutableMap<String, String> keyMap) {
4545
@Immutable
4646
abstract static class RouteLookupRequest {
4747

48-
// Names should match those in grpc.lookup.v1.RouteLookupRequest.Reason
48+
/** Names should match those in {@link io.grpc.lookup.v1.RouteLookupRequest.Reason} */
4949
enum Reason {
5050
REASON_UNKNOWN, // Unused
5151
REASON_MISS, // No data available in local cache
5252
REASON_STALE; // Data in local cache is stale
5353
}
5454

55-
// Reason for making this request.
55+
/** Reason for making this request. */
5656
abstract Reason reason();
5757

5858
/** Returns a map of key values extracted via key builders for the gRPC or HTTP request. */

rls/src/main/java/io/grpc/rls/RlsRequestFactory.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,6 @@ RouteLookupRequestKey create(String service, String method, Metadata metadata) {
9393
return RouteLookupRequestKey.create(rlsRequestHeaders.buildOrThrow());
9494
}
9595

96-
/** Creates a {@link RouteLookupRequest} using the given request lookup key and reason. */
97-
@CheckReturnValue
98-
RouteLookupRequest create(RouteLookupRequestKey routeLookupRequestKey,
99-
RouteLookupRequest.Reason reason) {
100-
return RouteLookupRequest.create(routeLookupRequestKey.keyMap(), reason);
101-
}
102-
10396
private ImmutableMap.Builder<String, String> createRequestHeaders(
10497
Metadata metadata, List<NameMatcher> keyBuilder) {
10598
ImmutableMap.Builder<String, String> rlsRequestHeaders = ImmutableMap.builder();

0 commit comments

Comments
 (0)