Skip to content

Commit a8f1f47

Browse files
committed
Save changes.
1 parent 2cadee6 commit a8f1f47

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

rls/src/test/java/io/grpc/rls/CachingRlsLbClientTest.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import static io.grpc.rls.CachingRlsLbClient.RLS_DATA_KEY;
2424
import static org.junit.Assert.assertNotNull;
2525
import static org.junit.Assert.assertSame;
26+
import static org.junit.Assert.fail;
2627
import static org.mockito.AdditionalAnswers.delegatesTo;
2728
import static org.mockito.ArgumentMatchers.any;
2829
import static org.mockito.ArgumentMatchers.argThat;
@@ -171,7 +172,6 @@ public void uncaughtException(Thread t, Throwable e) {
171172
private CachingRlsLbClient rlsLbClient;
172173
private Map<String, ?> rlsChannelServiceConfig;
173174
private String rlsChannelOverriddenAuthority;
174-
private Server server;
175175

176176
private void setUpRlsLbClient() {
177177
fakeThrottler.resetCounts();
@@ -348,16 +348,16 @@ public void controlPlaneTransientToReady_backOffEntriesRemovedAndPickerUpdated()
348348
routeLookupRequest,
349349
RouteLookupResponse.create(ImmutableList.of("target"), "header")));
350350

351+
fakeHelper.server.shutdown();
351352
fakeThrottler.nextResult = true;
352353
fakeBackoffProvider.nextPolicy = createBackoffPolicy(10, TimeUnit.MILLISECONDS);
353354

354355
CachedRouteLookupResponse resp = getInSyncContext(routeLookupRequest);
355356

356357
assertThat(resp.hasError()).isTrue();
357358

358-
// let it pass throttler
359-
fakeThrottler.nextResult = false;
360-
fakeClock.forwardTime(10, TimeUnit.MILLISECONDS);
359+
fakeHelper.server.start();
360+
Thread.sleep(10000);
361361
// Backoff entry evicted from cache.
362362
verify(evictionListener)
363363
.onEviction(eq(routeLookupRequest), any(CacheEntry.class), eq(EvictionType.EXPLICIT));
@@ -910,6 +910,8 @@ public void run() {
910910
private final class FakeHelper extends Helper {
911911

912912
SubchannelPicker lastPicker;
913+
Server server;
914+
ManagedChannel oobChannel;
913915
@Override
914916
public ManagedChannelBuilder<?> createResolvingOobChannelBuilder(
915917
String target, ChannelCredentials creds) {
@@ -953,7 +955,9 @@ public CleaningChannelBuilder overrideAuthority(String authority) {
953955
}
954956
}
955957

956-
return new CleaningChannelBuilder();
958+
CleaningChannelBuilder oobChannelBuilder = new CleaningChannelBuilder();
959+
oobChannel = oobChannelBuilder.build();
960+
return oobChannelBuilder;
957961
}
958962

959963
@Override

0 commit comments

Comments
 (0)