Skip to content

Commit ae61750

Browse files
committed
Addressing review comments: Made lookup reason always as cache miss after a backed off entry is reprocessed, and the style related comments. Added assertions for lookup reason in unit tests.
1 parent 9730840 commit ae61750

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

rls/src/main/java/io/grpc/rls/RlsProtoData.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,12 @@ abstract static class RouteLookupRequest {
4747

4848
/** Names should match those in {@link io.grpc.lookup.v1.RouteLookupRequest.Reason} */
4949
enum Reason {
50-
REASON_UNKNOWN, // Unused
51-
REASON_MISS, // No data available in local cache
52-
REASON_STALE; // Data in local cache is stale
50+
/** Unused */
51+
REASON_UNKNOWN,
52+
/** No data available in local cache */
53+
REASON_MISS,
54+
/** Data in local cache is stale */
55+
REASON_STALE;
5356
}
5457

5558
/** Reason for making this request. */

0 commit comments

Comments
 (0)