Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the stage info out of the karaoke beatmap. #1927

Open
andy840119 opened this issue Apr 9, 2023 · 5 comments
Open

Move the stage info out of the karaoke beatmap. #1927

andy840119 opened this issue Apr 9, 2023 · 5 comments
Labels
enhancement New feature or request Stage Anything about any kinds of stage.

Comments

@andy840119
Copy link
Member

I think finally the stage will be separated.
And will use the injection (e.g. IStageProvider) to get and edit the stage.

Will use the Workingbeatmp.GetStream() to read the stage file.

@andy840119 andy840119 added enhancement New feature or request Stage Anything about any kinds of stage. labels Apr 9, 2023
@andy840119
Copy link
Member Author

Need to make sure that working beatmap is able to save the file.

@andy840119
Copy link
Member Author

Also, we need something like StageChangeHandler to undo/redo the stage.

@andy840119
Copy link
Member Author

I think will start implement this after:

  1. Implement the preview stage info.
  2. Lazer is able to save/load customized beatmap.

It's too early for thinking about this.

@andy840119 andy840119 pinned this issue Apr 9, 2023
@andy840119
Copy link
Member Author

andy840119 commented Apr 9, 2023

Pin this issue for not forgot it.

@andy840119
Copy link
Member Author

andy840119 commented Apr 9, 2023

Also, should think about:

  • how to trigger the drawable hit-object to re-calculate the working stage(maybe trigger by the change handler or in the stage)? -> maybe use working beatmap to load the stage info from the json file and put into the karaoke beatmap? Not very well but it's a workable way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stage Anything about any kinds of stage.
Projects
None yet
Development

No branches or pull requests

1 participant