Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the check to check if element id in the beatmap/stage should have the instance. #2059

Open
andy840119 opened this issue Jul 5, 2023 · 3 comments
Labels
Checks Checks in the karaoke ruleset.

Comments

@andy840119
Copy link
Member

Inspired from the #2058.
And note that we need to finish the #2056 first.

用中文好了
簡單來說,我們需要確保 beatmap 內在任何操作,都不應該讓 property 內的 element id 找不到參考對象(object)
通常是因為 object 被刪除
e.g. 刪除掉 singer 後,lyric 的 singer id 卻沒有被清掉。

@andy840119
Copy link
Member Author

哭阿,這個 issue 會無限繁殖

@andy840119
Copy link
Member Author

Duplicated to the #2058
I think should rename this issue and focus on provide the check to check the null reference.

@andy840119 andy840119 changed the title Test should not have referenced element id that is not able to find the instance in the change handler test. Add the check to check if element id in the beatmap/stage should have the instance. Jul 10, 2023
@andy840119
Copy link
Member Author

  • CheckBeatmapElementId : Check element id should contains the reference in the beatmap.
  • CheckStageElementId: Check element id should contains the reference in the beatmap or stage.

另外需要想一下是不是要獨立寫這個 check ,因為可能會有機會 element id 並不是對應到想要的 instance (e.g. singer ids 裡面的 id 剛好是 lyric 的 id,應該要把這種可能檢查出來)

@andy840119 andy840119 added the Checks Checks in the karaoke ruleset. label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Checks Checks in the karaoke ruleset.
Projects
None yet
Development

No branches or pull requests

1 participant