You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should save CodegenObjectSchema for normal implementations. We benefit from the isObject check in templates meaning it's a normal object that you can construct. If we create a CodegenAbstractObjectSchema and a corresponding schema type, then we can generate our abstract objects that we use when making an implementation for an interface, but we won't accidentally try to use them for a purpose for which they're not intended, such as emitting code that does new X().
The text was updated successfully, but these errors were encountered:
I think we should save
CodegenObjectSchema
for normal implementations. We benefit from theisObject
check in templates meaning it's a normal object that you can construct. If we create aCodegenAbstractObjectSchema
and a corresponding schema type, then we can generate our abstract objects that we use when making an implementation for an interface, but we won't accidentally try to use them for a purpose for which they're not intended, such as emitting code that doesnew X()
.The text was updated successfully, but these errors were encountered: