Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the abstract flag from CodegenObjectSchema #20

Open
karlvr opened this issue Sep 7, 2021 · 0 comments
Open

Remove the abstract flag from CodegenObjectSchema #20

karlvr opened this issue Sep 7, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@karlvr
Copy link
Owner

karlvr commented Sep 7, 2021

I think we should save CodegenObjectSchema for normal implementations. We benefit from the isObject check in templates meaning it's a normal object that you can construct. If we create a CodegenAbstractObjectSchema and a corresponding schema type, then we can generate our abstract objects that we use when making an implementation for an interface, but we won't accidentally try to use them for a purpose for which they're not intended, such as emitting code that does new X().

@karlvr karlvr added the enhancement New feature or request label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant