Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Bump Kubernetes dependency from v1.30.2 to v1.31.2 #5796

Open
12 of 15 tasks
RainbowMango opened this issue Nov 9, 2024 · 3 comments
Open
12 of 15 tasks

[Umbrella] Bump Kubernetes dependency from v1.30.2 to v1.31.2 #5796

RainbowMango opened this issue Nov 9, 2024 · 3 comments
Assignees
Milestone

Comments

@RainbowMango
Copy link
Member

RainbowMango commented Nov 9, 2024

This issue is used to track Kubernetes dependency update tasks.

Prerequisites

Follow Up
Things should be cleaned up after the dependency bump.

References:

@RainbowMango
Copy link
Member Author

@seanlaii Thank you for reaching out and expressing your interest in contributing to the project.

I disabled the deprecation check in the previous PR to keep the PR at an appropriate size for review. Now it's time to enable this check and fix the deprecation warnings accordingly.
Please let me know if you are interested in this.

@seanlaii
Copy link
Contributor

seanlaii commented Nov 22, 2024

Hi @RainbowMango , thanks for the info!
Yes, I am interested in this.
Do I need to wait for sigs.k8s.io/custom-metrics-apiserver and sigs.k8s.io/metrics-server to be completed?

@RainbowMango
Copy link
Member Author

Thanks.

Do I need to wait for sigs.k8s.io/custom-metrics-apiserver and sigs.k8s.io/metrics-server to be completed?

No. All you need to do is remove the following line:

karmada/.golangci.yml

Lines 85 to 88 in fc1df77

staticcheck:
# TODO(@RainbowMango): Disable deprecation check temporary for Kubernetes dependency update.
# This is tracked by https://github.com/karmada-io/karmada/issues/5796.
checks: ["all", "-SA1019"]

And then get the warnings by running the following command:

hack/verify-staticcheck.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants