Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karmada Metrics Documentation Improvement #610

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

shivansh-bhatnagar18
Copy link

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Earlier, the documentation for Karmada metrics was not segregated according to their components and there was no clear demo/instructions as to how to query these metrics which is improved in this PR

Which issue(s) this PR fixes:
Fixes #425

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 23, 2024
@karmada-bot karmada-bot requested review from Poor12 and Tingtal May 23, 2024 13:16
@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label May 23, 2024
@karmada-bot
Copy link
Collaborator

Welcome @shivansh-bhatnagar18! It looks like this is your first PR to karmada-io/website 🎉

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 23, 2024
shivansh-bhatnagar18 and others added 8 commits May 23, 2024 18:54
Improvised the documentation for setting up the local development server

Signed-off-by: Shivansh Bhatnagar <[email protected]>
Signed-off-by: B1F030 <[email protected]>
Signed-off-by: Shivansh Bhatnagar <[email protected]>
Signed-off-by: B1F030 <[email protected]>
Signed-off-by: Shivansh Bhatnagar <[email protected]>
Signed-off-by: Shivansh Bhatnagar <[email protected]>
Signed-off-by: Shivansh Bhatnagar <[email protected]>
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango, samzong for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2024
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for those addition, removal, and replacement of $

@windsonsea
Copy link
Member

windsonsea commented Jul 5, 2024

ping @shivansh-bhatnagar18, could you take a look those conflicts and resolve it? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karmada metrics documentation improvement.
4 participants