Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake on ResourceModel page #715

Open
3 tasks
RainbowMango opened this issue Oct 17, 2024 · 3 comments
Open
3 tasks

Fix mistake on ResourceModel page #715

RainbowMango opened this issue Oct 17, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@RainbowMango
Copy link
Member

RainbowMango commented Oct 17, 2024

What would you like to be added:
Fix the mistake on ResourceModel page as discussed at #713 (comment)

Why is this needed:

@RainbowMango RainbowMango added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 17, 2024
@LavredisG
Copy link
Contributor

LavredisG commented Nov 15, 2024

Opened this: #736, check it out for any suggestions/corrections etc.

Also, I think in this line, this part is not correct "and the nodes of model2 and later as meeting the requirements.", according to our discussion, since memory request is not met by grade 2 nodes.

@LavredisG
Copy link
Contributor

I would also like to ask another question on the topic. Suppose that we want to schedule for example 3 Pod replicas. We get that cluster1 can fit 6 and that cluster2 can fit 5. In this case, cluster1 is chosen based on cluster resource modeling, but will it schedule all 3 of them at the same time? Or will it pick them serially, because in the first case we will get {cluster1: 3, cluster2: 0}, while in the second we will get {cluster1: 2, cluster2: 0}. Examples were based on 1-pod scheduling, so I couldn't figure what happens in that case.

@RainbowMango
Copy link
Member Author

Suppose that we want to schedule for example 3 Pod replicas. We get that cluster1 can fit 6 and that cluster2 can fit 5. In this case, cluster1 is chosen based on cluster resource modeling, but will it schedule all 3 of them at the same time?

Actually It depends on the scheduling policy. For example when dividing replicas as per StaticWeight, like 2:1, then cluster1 will have 2, and cluster2 will have 1.

I think the resource model is only used to figure out available replicas of each cluster, it doesn't control how to divide them. I also mentioned on #736 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants