Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linking to fonts in shadow dom #260

Open
bts-ncollins opened this issue Nov 5, 2021 · 5 comments
Open

Linking to fonts in shadow dom #260

bts-ncollins opened this issue Nov 5, 2021 · 5 comments

Comments

@bts-ncollins
Copy link

bts-ncollins commented Nov 5, 2021 •
edited
Loading

First of all, thanks for this repo, it plugs a hole that Vue has and React doesn't and it's working great for my project.

I've stumbled across one thing, with shadowDom enabled, I'm linking to fonts from Google they don't appear to work. It does the initial request and pulls the css file, but doesn't then get the WOFF so the font doesn't come through. Or in the case of Material Icons, they're rendered as placeholders.

I've tried importing using @import url("") in the scss and also with the <link href="" tag in the Vue file itself.

Any ideas how to get this working? I guess I could hold them locally from an npm package but this doesn't feel right.

Thanks again
@karol-f
Copy link
Owner

karol-f commented Nov 5, 2021

Can You please prepare CodeSandbox (e.g. fork this one - https://codesandbox.io/s/o1fsc)?

@allynsweet
Copy link

I encountered the same issue, I resolved it by creating a <link> tag in the created() lifecycle hook of my entry App.vue file, then appending that to the document's <head>:

created() {
    const fonts = document.createElement("link");
    fonts.type = "text/css";
    fonts.rel = "stylesheet";
    fonts.href = "https://fonts.googleapis.com/css2?family=Assistant:wght@500;700&display=swap";
    document.head.appendChild(fonts);
}

@SkyGopnik
Copy link

I encountered the same issue, I resolved it by creating a <link> tag in the created() lifecycle hook of my entry App.vue file, then appending that to the document's <head>:

created() {
    const fonts = document.createElement("link");
    fonts.type = "text/css";
    fonts.rel = "stylesheet";
    fonts.href = "https://fonts.googleapis.com/css2?family=Assistant:wght@500;700&display=swap";
    document.head.appendChild(fonts);
}

This really works, thanks.

@ElonTelos
Copy link

@allynsweet this seems to me that it adds the font globally ? not scoped or within the shadow root ?

@allynsweet
Copy link

@allynsweet this seems to me that it adds the font globally ? not scoped or within the shadow root ?

That is true, but adding it globally shouldn't matter unless for some reason the parent DOM has a font with the same name, but a different font as the shadow DOM (which seems very unlikely). But if it is likely for your use case, you could import the CSS file from your own server and name the font something obscure enough to be functionally unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@karol-f @bts-ncollins @allynsweet @SkyGopnik @ElonTelos