From 401341e127c4d12cfe277da9cb5715407272c578 Mon Sep 17 00:00:00 2001 From: Seth Ariel Green Date: Thu, 30 Jul 2020 15:25:12 -0400 Subject: [PATCH] Update Description to note `systemRequirements` For kicks, I ran ``` docker run --rm -it rocker/r-base:3.6.3 install.packages('remotes') remotes::install_github('karthik/holepunch') ``` And I got the following errors about missing system-level dependencies: ``` ------------------------- ANTICONF ERROR --------------------------- Configuration failed because libcurl was not found. Try installing: * deb: libcurl4-openssl-dev (Debian, Ubuntu, etc) * rpm: libcurl-devel (Fedora, CentOS, RHEL) * csw: libcurl_dev (Solaris) ``` and ``` ------------------------- ANTICONF ERROR --------------------------- Configuration failed because libxml-2.0 was not found. Try installing: * deb: libxml2-dev (Debian, Ubuntu, etc) * rpm: libxml2-devel (Fedora, CentOS, RHEL) * csw: libxml2_dev (Solaris) ``` This won't be strictly sufficient for a new user -- R doesn't have a system for automating the systemRequirements checks -- but it's a good start, and if efforts like https://github.com/r-hub/sysreqsdb take off, it might eventually suffice. Thanks either way for a great package! --- DESCRIPTION | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index a5d5620..9ceca6e 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -33,7 +33,8 @@ Imports: remotes, renv, usethis (>= 1.4.0) -Remotes: rstudio/renv +Remotes: rstudio/renv +SystemRequirements: , libcurl, libxml-2.0 Encoding: UTF-8 LazyData: true RoxygenNote: 7.1.0