Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the main window will leave the child window open #285

Open
captchaKing opened this issue Feb 15, 2022 · 1 comment
Open

Closing the main window will leave the child window open #285

captchaKing opened this issue Feb 15, 2022 · 1 comment
Labels
behaviour Concerns UI behaviour

Comments

@captchaKing
Copy link
Contributor

captchaKing commented Feb 15, 2022

As in description. To reproduce open Gallery example, press Edit button, close main window.

There's usually two types of dialogs in modern GUI's. The ones that block parent's window event loop, and others don't. But all of them close with parent window.

@dhardy
Copy link
Collaborator

dhardy commented Feb 15, 2022

Well,

  • closing the main window will leave the child window open
  • using the App → Quit menu will close the whole application

So I think the title is not accurate.

But yes, the parent window should probably be blocked while the child window is open. (Similar but slightly different, the base layer should be blocked when a pop-up is open: try resizing the gallery so that it's scrollable, opening the combobox, then scrolling the base layer with the mouse-wheel.)

@captchaKing captchaKing changed the title TkAction::EXIT will not close application if some dialogs are open Closing the main window will leave the child window open Feb 16, 2022
@dhardy dhardy added the behaviour Concerns UI behaviour label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviour Concerns UI behaviour
Projects
None yet
Development

No branches or pull requests

2 participants