Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl-enter (insert line below, insert line above) in middle of line not adding /// #98

Open
WebFreak001 opened this issue Jul 20, 2020 · 7 comments
Assignees
Labels

Comments

@WebFreak001
Copy link

When having

/// <summary>
/// Hello| world
/// </summary>

pressing ctrl-enter or ctrl-shift-enter (Insert line below, insert line above) at the indicated location will insert a new line but not insert any ///.

With insert line below it will enter it if the cursor was at the very right, with insert line above it seems like it never inserts it.

@kasecato kasecato self-assigned this Jul 24, 2020
@kasecato kasecato added the bug label Jul 24, 2020
@kasecato
Copy link
Owner

#98

kasecato added a commit that referenced this issue Jul 26, 2020
Fixed #98 ctrl-enter (insert line below, insert line above) in middle…
@kasecato
Copy link
Owner

@WebFreak001 Many thank you for your but report. I just fixed this issue on v0.1.15. Please check it 👍

@kasecato kasecato reopened this Jul 26, 2020
@WebFreak001

This comment has been minimized.

@WebFreak001
Copy link
Author

I'm getting exceptions while typing in 0.1.15:

ypeError: Cannot read property 'text' of undefined
	at DocommentDomainCSharp.IsTriggerDocomment (c:\Users\jurzitza\.vscode\extensions\k--kato.docomment-0.1.15\out\src\Domain\Lang\DocommentDomainCSharp.js:30:39)
	at DocommentDomainCSharp.Execute (c:\Users\jurzitza\.vscode\extensions\k--kato.docomment-0.1.15\out\src\Domain\DocommentDomain.js:23:19)
	at DocommentControllerCSharp._onEvent (c:\Users\jurzitza\.vscode\extensions\k--kato.docomment-0.1.15\out\src\Controller\DocommentController.js:55:31)
	at DocommentControllerCSharp.<anonymous> (c:\Users\jurzitza\.vscode\extensions\k--kato.docomment-0.1.15\out\src\Controller\DocommentController.js:19:22)

Ctrl-Enter is still broken:
cursor in middle of line
ctrl enter not inserting doc comment

Ctrl-Shift-Enter seems to work though.

@kasecato kasecato added this to the v0.1.16 milestone Jul 27, 2020
kasecato added a commit that referenced this issue Jul 27, 2020
@kasecato
Copy link
Owner

Thank you @WebFreak001 . I reproduced it. I just fixed it on v0.1.16. I'm sorry to keep asking you to do this, but please check it.

@kasecato kasecato reopened this Jul 27, 2020
@WebFreak001
Copy link
Author

seems to works fine now

Still getting the stacktraces in the developer tools which you might want to fix eventually though.

@kasecato kasecato removed this from the v0.1.16 milestone Jul 28, 2020
@kasecato kasecato reopened this Jul 28, 2020
@kasecato
Copy link
Owner

@WebFreak001 Sorry for reopening this issue. I reverted this because of #108 . Currently, we can't use ctrl+shift+enter. I'll fix it until this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants