Judge: Implement opendata-v2 #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvizelPritula
changed the title
5K1PY
requested changes
Nov 22, 2024
| @@ -579,6 +573,7 @@ def __init__( | |||
| ) | |||
| self.judge = judge | |||
| self.seed = seed | |||
| self.points_file = TaskPath.points_file(self._env, self.judge_log_file.name) | |||
There was a problem hiding this comment.
What? Judge is supposed to report everything to stderr.
| def return_code_wa(self) -> int: | ||
| return 1 | ||
| assert isinstance(result.stdout_file, TaskPath) | ||
| with open(result.stdout_file.path) as file: |
There was a problem hiding this comment.
stderr parsing deserves it's own function.
| "The value of the POINTS key was not a valid decimal", | ||
| result, | ||
| ) | ||
|
|
There was a problem hiding this comment.
It would be best to allow only LOG and NOTE as the other keys.
Co-authored-by: Daniel Skýpala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #193.