Issues loading specific seeds

[erikaxel]

I had some small issues loading specific seeds. Some documentation issues and one bug.

Wrong path suggested?
The docs suggest using db/seeds/tests/cases. I didn't get that to work, instead I used db/seeds/cases. In the dummy app, the seeds are put under db/seeds/test/cases (note the lacking s). However, since the rest of the list is without the specific environment, I think it would make sense to just use db/seeds/cases in the documentation here?

Add rspec suggestion
The documentation only suggests how to load seeds from minitest, should we add it for rspec as well?

RSpec.describe 'Pagination' do
  before { seed "cases/pagination" }
end

seed silently fails on missing file
Since I had the wrong path (due to the first documentation issue) my tests failed, but it took me a while to figure out because seed silently fails if it doesn't find the file. I think it would have been easier to figure out if it complained on missing files.

[kaspth]

The docs suggest using db/seeds/tests/cases. I didn't get that to work, instead I used db/seeds/cases. In the dummy app, the seeds are put under db/seeds/test/cases (note the lacking s).

Yeah, that's a typo. I spotted it a while ago, but then forgot to fix it. I just fixed it in #97.

However, since the rest of the list is without the specific environment, I think it would make sense to just use db/seeds/cases in the documentation here?

The nesting is on purpose, since cases doesn't really make sense outside of the test environment. It's also trying to mirror TestCase as a name ala ActiveSupport::TestCase.

[kaspth]

The documentation only suggests how to load seeds from minitest, should we add it for rspec as well?

Hm. I haven't used RSpec much personally, so I'm wondering about RSpec specific documentation maintenance in general. I suppose we could add that snippet.

[kaspth]

Ok, documenting the RSpec version in #98

[kaspth]

Since I had the wrong path (due to the first documentation issue) my tests failed, but it took me a while to figure out because seed silently fails if it doesn't find the file. I think it would have been easier to figure out if it complained on missing files.

Yeah, we should probably raise in case no files are found.

[kaspth]

After #99, we're now raising in case a pattern can't be found. So for seed :accounts, :missing, we'll raise that :missing can't find any files.

[erikaxel]

The nesting is on purpose, since cases doesn't really make sense outside of the test environment. It's also trying to mirror TestCase as a name ala ActiveSupport::TestCase.

We were actually thinking that reusing special cases between dev/test makes a lot of sense for us. The case of pagination is a good example. When we want to develop on a pagination feature, it is usually a hassle to create all the objects needed to force the pagination to work, so instead by including it in the default seed, all developers would have easy access to the case. This is even more true when the cases get more esoteric and difficult to setup. So we were planning on adding something like the following in seeds.rb:

if Rails.env.development?
    seed 'cases/pagination' 
    # and all other special cases we want in default dev
end

[kaspth]

We were actually thinking that reusing special cases between dev/test makes a lot of sense for us. The case of pagination is a good example.

Ahh, I see! That's interesting.

So we were planning on adding something like the following in seeds.rb:

Ah yeah, I can see what you mean. I think I'd do this:

if Rails.env.development?
  seed :cases # Loads from db/seeds/cases/**/* and db/seeds/development/cases/**/*
end

This lets you add shared and development specific cases without needing to update db/seeds.rb. And in tests you can then seed "cases/<something>" to get them on a case-by-case basis.

I'll need to think about this more and I probably want to document this in the README too.

[kaspth]

Ok, I just used a cases/lookbook over in #100 and I'm really liking it.