Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not implemented correctly. #1

Open
GravisZro opened this issue Jul 1, 2024 · 2 comments
Open

Not implemented correctly. #1

GravisZro opened this issue Jul 1, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@GravisZro
Copy link

This doesn't implement SIEVE correctly.

Specifically, I see no indication that...

  • a record is made when a node has been visited, the core mechanism used in cache eviction.
  • cache eviction ever happens
@kassane
Copy link
Owner

kassane commented Jul 6, 2024

Hi @GravisZro,

Yes, this remake is not following the original proposal and does not match the Dlang implementation.
It's not ideal and I'll need to review the current implementation.

This current implementation was a response to the initial proposal below.
20cdbd1

The Benchmark previously carried out based on the old implementation, resulting poor performance with std::unordered_map.

@kassane kassane added the good first issue Good for newcomers label Jul 6, 2024
@GravisZro
Copy link
Author

My suggestion is to revert to the poorly performing version that worked correctly and then modify it. Slow is always better than non-functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants