Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database interface should accept context.Context for all methods #32

Open
gf3 opened this issue Jul 22, 2022 · 0 comments
Open

Database interface should accept context.Context for all methods #32

gf3 opened this issue Jul 22, 2022 · 0 comments

Comments

@gf3
Copy link

gf3 commented Jul 22, 2022

The Database interface should be duplicated and modified (e.g. DatabaseWithCtx) to support receiving the request context for each method call.

For example:

type Database interface {
	Acquire(sid string, expires time.Duration) LifeTime
	// ...
}

// Should become this ↓
type DatabaseWithCtx interface {
	Acquire(ctx context.Context, sid string, expires time.Duration) LifeTime
	// ...
}

This is important for things like tracing, logging, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant