Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kathrasis is not extendable #458

Open
bmaehr opened this issue Mar 21, 2018 · 0 comments
Open

Kathrasis is not extendable #458

bmaehr opened this issue Mar 21, 2018 · 0 comments

Comments

@bmaehr
Copy link

bmaehr commented Mar 21, 2018

In Katharsis almost all not-public methods are marked as private instead of protected. If overriding one method it is necessary to duplicate nearly the whole class.

Additionally lines like

module.addResourceInformationBuilder(new AnnotationResourceInformationBuilder(resourceFieldNameTransformer));

or

DefaultResourceInstanceBuilder<?> instanceBuilder = new DefaultResourceInstanceBuilder(resourceClass);

or

return objectMapper.readValue(requestBody, RequestBody.class);

in the middle of the code makes it difficult to extend the framework. You should implement more like the spring-framework is built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant