Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding and deleting an invoice line item without entering values causes a failure on submittal #20

Open
kbaley opened this issue May 7, 2020 · 0 comments

Comments

@kbaley
Copy link
Owner

kbaley commented May 7, 2020

InvoicesController is expecting numbers for Quantity and UnitAmount and if you submit without these (even if they are deleted), the request is rejected.

Solutions:

  • Validation on client to ensure legitimate line items have proper data
  • Line items that are added and deleted in the same session can be discarded. No need to include them in the request
  • When deleting a line item with no numbers, default to 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant