Replace hashcode assertions with equaility assertions, backed by equalsverifier contract test. this resolves the hardcoded hashcodes causing stochastic test failures depending on execution order/enviroment, test cleanup to follow

Author: dauglyon

src/test/java/us/kbase/test/auth2/lib/EmailAddressTest.java

@@ -19,7 +19,7 @@ public class EmailAddressTest {
 	public void construct() throws Exception {
 		final EmailAddress ea = new EmailAddress("   [email protected]   \n");
 		assertThat("incorrect email", ea.getAddress(), is("[email protected]"));
-		assertThat("incorrect hashCode", ea.hashCode(), is(1827947467));
+		assertThat("incorrect equality", ea, is(new EmailAddress("[email protected]")));
 		assertThat("incorrect toString", ea.toString(), is("EmailAddress [[email protected]]"));
 	}
 

src/test/java/us/kbase/test/auth2/lib/UserNameTest.java

@@ -24,13 +24,13 @@ public void root() throws Exception {
 		assertThat("incorrect username", un.getName(), is("***ROOT***"));
 		assertThat("incorrect is root", un.isRoot(), is(true));
 		assertThat("incorrect toString", un.toString(), is("UserName [getName()=***ROOT***]"));
-		assertThat("incorrect hashCode" , un.hashCode(), is(-280622915));
-		
+		assertThat("incorrect equality", un, is(UserName.ROOT));
+
 		final UserName un2 = UserName.ROOT;
 		assertThat("incorrect username", un2.getName(), is("***ROOT***"));
 		assertThat("incorrect is root", un2.isRoot(), is(true));
 		assertThat("incorrect toString", un2.toString(), is("UserName [getName()=***ROOT***]"));
-		assertThat("incorrect hashCode" , un2.hashCode(), is(-280622915));
+		assertThat("incorrect equality", un2, is(new UserName("***ROOT***")));
 	}
 
 	@Test
@@ -39,7 +39,7 @@ public void construct() throws Exception {
 		assertThat("incorrect username", un.getName(), is("a8nba9"));
 		assertThat("incorrect is root", un.isRoot(), is(false));
 		assertThat("incorrect toString", un.toString(), is("UserName [getName()=a8nba9]"));
-		assertThat("incorrect hashCode" , un.hashCode(), is(-1462848190));
+		assertThat("incorrect equality", un, is(new UserName("a8nba9")));
 	}
 
 	@Test

src/test/java/us/kbase/test/auth2/lib/identity/RemoteIdentityTest.java

@@ -22,7 +22,7 @@ public void remoteDetailsWithAllFields() throws Exception {
 		assertThat("incorrect fullname", dets.getFullname(), is("full"));
 		assertThat("incorrect email", dets.getEmail(), is("email"));
 		assertThat("incorrect mfa authenticated", dets.getMfa(), is(MfaStatus.UNKNOWN));
-		assertThat("incorrect hashcode", dets.hashCode(), is(44648981));
+		assertThat("incorrect equality", dets, is(new RemoteIdentityDetails("user", "full", "email")));
 		assertThat("incorrect toString()", dets.toString(),
 				is("RemoteIdentityDetails [username=user, fullname=full, email=email, mfa=UNKNOWN]"));
 	}
@@ -34,16 +34,15 @@ public void remoteDetailsWithEmptyFields() throws Exception {
 		assertThat("incorrect fullname", dets.getFullname(), is((String) null));
 		assertThat("incorrect email", dets.getEmail(), is((String) null));
 		assertThat("incorrect mfa authenticated", dets.getMfa(), is(MfaStatus.UNKNOWN));
-		assertThat("incorrect hashcode", dets.hashCode(), is(547016802));
 		assertThat("incorrect toString()", dets.toString(),
 				is("RemoteIdentityDetails [username=user, fullname=null, email=null, mfa=UNKNOWN]"));
-		
+
 		final RemoteIdentityDetails dets2 = new RemoteIdentityDetails("user", null, null);
 		assertThat("incorrect username", dets2.getUsername(), is("user"));
 		assertThat("incorrect fullname", dets2.getFullname(), is((String) null));
 		assertThat("incorrect email", dets2.getEmail(), is((String) null));
 		assertThat("incorrect mfa authenticated", dets2.getMfa(), is(MfaStatus.UNKNOWN));
-		assertThat("incorrect hashcode", dets2.hashCode(), is(547016802));
+		assertThat("incorrect equality", dets2, is(dets));
 		assertThat("incorrect toString()", dets2.toString(),
 				is("RemoteIdentityDetails [username=user, fullname=null, email=null, mfa=UNKNOWN]"));
 	}
@@ -77,7 +76,7 @@ public void remoteId() throws Exception {
 		assertThat("incorrect unique id", id.getID(), is("5c7d96a3dd7a87850a2ef34087565a6e"));
 		// check unique id again to check memoization doesn't change result
 		assertThat("incorrect unique id", id.getID(), is("5c7d96a3dd7a87850a2ef34087565a6e"));
-		assertThat("incorrect hashcode", id.hashCode(), is(3118804));
+		assertThat("incorrect equality", id, is(new RemoteIdentityID("foo", "bar")));
 		assertThat("incorrect toString()", id.toString(),
 				is("RemoteIdentityID [provider=foo, id=bar]"));
 	}
@@ -116,7 +115,8 @@ public void identity() throws Exception {
 		final RemoteIdentity ri = new RemoteIdentity(id, dets);
 		assertThat("incorrect id", ri.getRemoteID(), is(id));
 		assertThat("incorrect details", ri.getDetails(), is(dets));
-		assertThat("incorrect hashcode", ri.hashCode(), is(-237603620));
+		assertThat("incorrect equality", ri, is(new RemoteIdentity(
+				new RemoteIdentityID("p", "i"), new RemoteIdentityDetails("u", "f", "e"))));
 		assertThat("incorrect toString()", ri.toString(),
 				is("RemoteIdentity [remoteID=RemoteIdentityID [provider=p, id=i], " +
 						"details=RemoteIdentityDetails [username=u, fullname=f, email=e, mfa=UNKNOWN]]"));