Skip to content

Commit 5cfaac3

Browse files
authored
Merge pull request #3009 from kbase/develop-to-main
DATAUP-697 Merge to main for 5.1.0 release
2 parents 087d387 + 711ee1b commit 5cfaac3

File tree

210 files changed

+14119
-11801
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

210 files changed

+14119
-11801
lines changed

.flake8

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ max-line-length = 88
33
# E203: whitespace before ‘,’, ‘;’, or ‘:’
44
# E501: line length
55
# W503: line break after binary operator
6-
ignore = E203, E501, W503
6+
ignore = E203, E501, W503, D, DAR
7+
extend-select = B902, B903, B904
78
extend-exclude =
89
*.pyc,
910
.github,

.github/workflows/build_and_push_image.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
if [ ${{ github.base_ref }} == 'main' ]; then
2525
branch=''
2626
else
27-
branch="-""${{ github.base_ref }}"
27+
branch=`"-""${{ github.base_ref }}" | awk '{print tolower($0)}'`
2828
fi
2929
narrative_version=`grep '\"version\":' src/config.json.templ | awk '{print $2}' | sed 's/"//g'`
3030
narrative_git_hash=`grep '\"git_commit_hash\":' src/config.json.templ | awk '{print $2}' | sed 's/"//g' | sed 's/,//'`

.github/workflows/build_test_pr.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
name: Build Dev Image
33
on:
44
pull_request:
5-
branches:
6-
- develop
5+
branches-ignore:
6+
- main
77
types:
88
- opened
99
- synchronize

.github/workflows/build_truss_pr.yaml

Lines changed: 0 additions & 32 deletions
This file was deleted.

.github/workflows/build_truss_push.yaml

Lines changed: 0 additions & 46 deletions
This file was deleted.

.github/workflows/integration_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
if [ ${{ github.base_ref }} == 'main' ]; then
3131
branch=''
3232
else
33-
branch="-""${{ github.base_ref }}"
33+
branch=`"-""${{ github.base_ref }}" | awk '{print tolower($0)}'`
3434
fi
3535
narrative_version=`grep '\"version\":' src/config.json.templ | awk '{print $2}' | sed 's/"//g'`
3636
narrative_git_hash=`grep '\"git_commit_hash\":' src/config.json.templ | awk '{print $2}' | sed 's/"//g' | sed 's/,//'`

.github/workflows/manual_build.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
name: Build and Tag Latest Image
2+
3+
# Controls when the workflow will run
4+
on:
5+
# Manually triggers the workflow on the develop branch
6+
workflow_dispatch:
7+
inputs:
8+
branch:
9+
description: 'Branch to build the new image from'
10+
required: true
11+
default: 'develop'
12+
type: choice
13+
options:
14+
- develop
15+
- main
16+
17+
jobs:
18+
run_build_and_push:
19+
runs-on: ubuntu-latest
20+
steps:
21+
-
22+
name: say hello
23+
run: echo "hello world"

.github/workflows/unit_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
if [ ${{ github.base_ref }} == 'main' ]; then
2929
branch=''
3030
else
31-
branch="-""${{ github.base_ref }}"
31+
branch=`"-""${{ github.base_ref }}" | awk '{print tolower($0)}'`
3232
fi
3333
narrative_version=`grep '\"version\":' src/config.json.templ | awk '{print $2}' | sed 's/"//g'`
3434
narrative_git_hash=`grep '\"git_commit_hash\":' src/config.json.templ | awk '{print $2}' | sed 's/"//g' | sed 's/,//'`

RELEASE_NOTES.md

Lines changed: 67 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,74 @@ The Narrative Interface allows users to craft KBase Narratives using a combinati
44

55
This is built on the Jupyter Notebook v6.0.2 (more notes will follow).
66

7+
### Version 5.1.0
8+
- PTV-1783 - fixed issue where the previous object revert option was unavailable
9+
- DATAUP-639 - fix problems with dynamic dropdown app cell input
10+
- selected value wasn't being displayed properly after a page reload or cell refresh
11+
- selected value wasn't being displayed in view-only version
12+
- "Loading..." message wasn't displayed while fetching data from a service.
13+
- Update the dynamic dropdown to support the `exact_match_on` field in app specs.
14+
- Add a copy button to the dynamic dropdown - this will copy the most relevant text from the dropdown to the clipboard.
15+
- For dropdowns with an `exact_match_on` field, this will copy the contents of that field (e.g. for those that present taxonomy ids for a species, this copies just the scientific name)
16+
- For dropdowns that go against the FTP staging area, this copies the file name and path.
17+
- For other dropdowns, this copies the formatted text
18+
- DATAUP-751 - add link to staging area docs in the upload tour
19+
- DATAUP-753 - alter the error text for Select input boxes in app cells to be a bit more generalized.
20+
- DATAUP-756 - add a copy button for other, non-dynamic dropdowns. This copies the displayed text to the clipboard.
21+
22+
Dependency Changes
23+
- Javascript dependency updates
24+
- @wdio/browserstack-service: 7.16.16 -> 7.19.7
25+
- @wdio/cli: 7.16.16 -> 7.19.6
26+
- @wdio/local-runner: 7.16.6 -> 7.19.3
27+
- @wdio/mocha-framework: 7.16.15 -> 7.20.0
28+
- @wdio/selenium-standalone-service: 7.16.16 -> 7.19.1
29+
- @wdio/spec-reporter: 7.16.14 -> 7.19.1
30+
- autoprefixer: 10.2.6 -> 10.4.5
31+
- commander: 9.0.0 -> 9.3.0
32+
- chromedriver: 100.0.0 -> 101.0.0
33+
- corejs-typeahead: 1.6.1 -> 1.3.1
34+
- datatables.net: 1.11.3 -> 1.12.1
35+
- datatables.net-bs 1.11.5 -> 1.12.1
36+
- datatables.net-buttons-bs: 1.4.2 -> 2.2.3
37+
- ejs: 3.1.6 -> 3.1.7
38+
- eslint: 8.14.0 -> 8.16.0
39+
- grunt: 1.4.1 -> 1.5.3
40+
- grunt-contrib-concat: 1.0.1 -> 2.1.0
41+
- handlebars: 4.0.5 -> 4.7.7
42+
- jasmine-core: 4.0.0 -> 4.1.0
43+
- jquery-nearest: 1.3.1 -> 1.4.0
44+
- jquery-ui: 1.12.1 -> 1.13.1
45+
- js-yaml: 3.3.1 -> 3.14.1
46+
- karma-jasmine: 4.0.1 -> 5.0.1
47+
- karma-jasmine-matchers: 4.0.2 -> 5.0.0
48+
- postcss-remove-comments: 5.0.1 -> 5.1.2
49+
- postcss-cli: 8.3.1 -> 9.1.0
50+
- postcss-scss: 3.0.5 -> 4.0.4
51+
- pure-uuid: 1.4.2 -> 1.6.2
52+
- sass: 1.34.1 -> 1.51.0
53+
- selenium-standalone: 8.0.9 -> 8.0.10
54+
- selenium-webdriver: 4.1.1 -> 4.1.2
55+
- spark-md5: 3.0.0 -> 3.0.2
56+
- underscore: 1.8.3 -> 1.13.3
57+
- webdriverio: 7.16.16 -> 7.19.7
58+
59+
- Python dependency updates
60+
- beautifulsoup4: 4.8.1 -> 4.11.1
61+
- cryptography: 3.3.2 -> 36.0.2
62+
- html5lib: 1.0.1 -> 1.1
63+
- idna: 2.8 -> 3.3
64+
- jinja2: 3.1.1 -> 3.0.3
65+
- plotly: 5.6.0 -> 5.7.0
66+
- pygments: 2.11.2 -> 2.12.0
67+
- jupyter-console: 6.0.0 -> 6.4.3
68+
- jsonschema: 4.4.0 -> 3.2.0
69+
- pymongo: 4.1.0 -> 4.1.1
70+
- pyopenssl: 19.0.0 -> 22.0.0
71+
- setuptools: 62.0.0 -> 62.1.0
72+
773
### Version 5.0.3
8-
- DATAUP-641
74+
- DATAUP-641
975
- Adds custom error messages when app cell dropdown menu inputs are incorrect in various different ways.
1076
- Adds custom error messages when app cell checkboxes are initialized with non binary data (should only happen with a bulk import cell from a spreadsheet file)
1177
- Adds custom error messages when app cell numeric inputs are initialized with non-numeric data.

docs/deploy_narrative.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ The [next](https://next.kbase.us), [appdev](https://appdev.kbase.us), and [produ
7979

8080
### Deploying Narrative-Refactor
8181

82-
The [narrative-refactor](https://narrative-refactor.kbase.us) image is automatically built against the "truss" branch of the repo and is called narrative-truss:pr### when still in a PR state or narrative-truss:latest after merge. The images can be found here: https://github.com/orgs/kbase/packages
82+
The [narrative-refactor](https://narrative-refactor.kbase.us) image is automatically built against the "develop" branch of the repo and is called narrative-develop:pr### when still in a PR state or narrative-develop:latest after merge. The images can be found here: https://github.com/orgs/kbase/packages
8383

8484
### Deploying Narrative-Dev
8585
The [narrative-dev](https://narrative-dev.kbase.us) environment is meant for pre-release and iterative testing of new UI features and changes. As such, this isn't always tied to any particular branch, although it is most often set to deploy the production image. Contact a DevOps team member if there are any questions.
@@ -117,7 +117,7 @@ Once a pull request is merged from `develop` to `main` a new _production_ image
117117
| Environment | Image URL |
118118
| ----------- | -------------------------------------------------------------- |
119119
| CI | ghcr.io/kbase/narrative-develop:latest |
120-
| Narrative-refactor| ghcr.io/kbase/narrative-truss:latest |
120+
| Narrative-refactor| ghcr.io/kbase/narrative-develop:latest |
121121
| Appdev | ghcr.io/kbase/narrative:appdev |
122122
| Next | ghcr.io/kbase/narrative:next |
123123
| Production | ghcr.io/kbase/narrative:prod |

0 commit comments

Comments
 (0)