Skip to content

Commit c0e18b6

Browse files
authored
Merge pull request #1645 from briehl/redirect-loading
migrate from pr #1632 to a master feature branch
2 parents 37a7f43 + 1aeda20 commit c0e18b6

File tree

8 files changed

+14
-11
lines changed

8 files changed

+14
-11
lines changed

Diff for: RELEASE_NOTES.md

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ The Narrative Interface allows users to craft KBase Narratives using a combinati
33

44
This is built on the Jupyter Notebook v6.0.2 (more notes will follow).
55

6+
### Version 4.1.2
7+
- Redirect to the interstitial loading page after shutting down a Narrative session, instead of letting the backend server do the redirect.
8+
69
### Version 4.1.1
710
- Fix sort order in Narratives panel - should be by most recently saved.
811
- Add better error support in data staging uploader - if an upload directory is not available, you should be able to return to the root directory without trouble.

Diff for: bower.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "kbase-narrative",
3-
"version": "4.1.1",
3+
"version": "4.1.2",
44
"homepage": "https://kbase.us",
55
"dependencies": {
66
"bluebird": "3.4.7",

Diff for: kbase-extension/static/kbase/js/kbaseNarrative.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -811,20 +811,20 @@ define([
811811
* If it can't, or if this is being run locally, it pops up an alert saying so.
812812
*/
813813
Narrative.prototype.updateVersion = function () {
814-
var user = NarrativeLogin.sessionInfo.user; //.loginWidget($('#signin-button')).session('user_id');
814+
var user = NarrativeLogin.sessionInfo.user;
815815
Promise.resolve(
816816
$.ajax({
817817
contentType: 'application/json',
818818
url: '/narrative_shutdown/' + user,
819819
type: 'DELETE',
820820
crossDomain: true
821821
}))
822-
.then(function () {
823-
setTimeout(function () {
824-
location.reload(true);
822+
.then(() => {
823+
setTimeout(() => {
824+
location.replace(`/load-narrative.html?n=${this.workspaceId}&check=true`);
825825
}, 200);
826826
})
827-
.catch(function (error) {
827+
.catch((error) => {
828828
window.alert('Unable to update your Narrative session\nError: ' + error.status + ': ' + error.statusText);
829829
console.error(error);
830830
});

Diff for: package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "kbase-narrative-core",
33
"description": "Core components for the KBase Narrative Interface",
4-
"version": "4.1.1",
4+
"version": "4.1.2",
55
"private": true,
66
"repository": "github.com/kbase/narrative",
77
"devDependencies": {

Diff for: src/biokbase/narrative/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
__all__ = ['magics', 'common', 'handlers', 'contents', 'services', 'widgetmanager']
22

33
from semantic_version import Version
4-
__version__ = Version("4.1.1")
4+
__version__ = Version("4.1.2")
55
version = lambda: __version__
66

77
# if run directly:

Diff for: src/config.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -262,5 +262,5 @@
262262
"showDelay": 750
263263
},
264264
"use_local_widgets": true,
265-
"version": "4.1.1"
265+
"version": "4.1.2"
266266
}

Diff for: src/config.json.templ

+1-1
Original file line numberDiff line numberDiff line change
@@ -321,5 +321,5 @@
321321
"showDelay": 750
322322
},
323323
"use_local_widgets": true,
324-
"version": "4.1.1"
324+
"version": "4.1.2"
325325
}

0 commit comments

Comments
 (0)