Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: syncedResources state should be Pending when APIResourceImport is missing #28

Open
lionelvillard opened this issue Mar 28, 2023 · 3 comments
Open

bug: syncedResources state should be Pending when APIResourceImport is missing #28

lionelvillard opened this issue Mar 28, 2023 · 3 comments
Assignees
@rahulii
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@lionelvillard
Copy link

Describe the bug

The SyncTarget reconciler sets the syncedResources state (for a given resource) to Incompatible when no corresponding APIResourceImport object is found. The Incompatible state indicates the resource schema is incompatible with the physical cluster schema, which I think in this case is wrong. The Pending state is better as it indicates the syncer was not able to report compatibility of the resource yet.

This line of code should be changed: https://github.com/kcp-dev/kcp/blob/main/pkg/reconciler/workload/synctargetexports/synctargetcompatible_reconcile.go#L118

Steps To Reproduce

Create a SyncTarget.

Expected Behaviour

Set state to Pending.

Additional Context

No response
@lionelvillard lionelvillard added the kind/bug Categorizes issue or PR as related to a bug. label Mar 28, 2023
@davidfestal davidfestal added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 29, 2023
@rahulii
Copy link

rahulii commented Mar 29, 2023

/assign

@rahulii rahulii mentioned this issue Mar 29, 2023
Closed
@mjudeikis
Copy link
Contributor

/transfer-issue contrib-tmc

1 similar comment
@mjudeikis
Copy link
Contributor

/transfer-issue contrib-tmc

@kcp-ci-bot kcp-ci-bot transferred this issue from kcp-dev/kcp Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulii rahulii

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
kcp
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 change state to pending state in case no corresponding APIResourceImp… Rahul-Sawra/kcp
4 participants
@davidfestal @mjudeikis @lionelvillard @rahulii