Add TODO to CR / CRB deletion to indicate GC should handle

Adds a TODO to the ClusterRole and ClusterRoleBinding deletion to
indicate that cleanup should be handled by the garbage collection
controller when implemented.

Signed-off-by: hasheddan <[email protected]>

Author: hasheddan

pkg/apis/tenancy/v1alpha1/helper/helper_test.go

@@ -20,6 +20,7 @@ import (
 	"testing"
 
 	"github.com/kcp-dev/logicalcluster/v2"
+
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 

pkg/reconciler/tenancy/clusterworkspacedeletion/clusterworkspace_deletion_controller.go

@@ -262,6 +262,10 @@ func (c *Controller) finalizeWorkspace(ctx context.Context, workspace *tenancyv1
 			listOpts := metav1.ListOptions{
 				LabelSelector: helper.WorkspaceLabelSelector(workspace.Name),
 			}
+
+			// TODO(hasheddan): ClusterRole and ClusterRoleBinding cleanup
+			// should be handled by garbage collection when the controller is
+			// implemented.
 			if err := c.kubeClusterClient.Cluster(clusterName).RbacV1().ClusterRoles().DeleteCollection(ctx, backgroudDeletion, listOpts); err != nil && !apierrors.IsNotFound(err) {
 				return fmt.Errorf("could not delete clusterroles for workspace %s: %w", clusterName, err)
 			}