btrfs-progs: tree-stats: accept numeric or text tree id for -t

Allow specification of string tree names same as dump-tree -t.

Pull-request: #1025
Signed-off-by: David Sterba <[email protected]>

Author: SaltyKitkat

Documentation/btrfs-inspect-internal.rst

@@ -317,8 +317,17 @@ tree-stats [options] <device>
         -b|--raw
                 raw numbers in bytes, without the *B* suffix
 
-        -t <treeid>
-                Print stats only for the given treeid.
+        -t <tree_id>
+                print only the tree with the specified ID, where the ID can be numerical or
+                common name in a flexible human readable form
+
+                The tree id name recognition rules:
+
+                * case does not matter
+                * the C source definition, e.g. BTRFS_ROOT_TREE_OBJECTID
+                * short forms without BTRFS\_ prefix, without _TREE and _OBJECTID suffix, e.g. ROOT_TREE, ROOT
+                * convenience aliases, e.g. DEVICE for the DEV tree, CHECKSUM for CSUM
+                * unrecognized ID is an error
         --human-readable
                 print human friendly numbers, base 1024, this is the default
 

cmds/inspect-tree-stats.c

@@ -36,6 +36,7 @@
 #include "common/messages.h"
 #include "common/open-utils.h"
 #include "common/string-utils.h"
+#include "common/parse-utils.h"
 #include "common/units.h"
 #include "cmds/commands.h"
 
@@ -441,7 +442,7 @@ static const char * const cmd_inspect_tree_stats_usage[] = {
 	"",
 	OPTLINE("-b", "raw numbers in bytes"),
 	HELPINFO_UNITS_LONG,
-	OPTLINE("-t <rootid>", "print only tree with the given rootid"),
+	OPTLINE("-t <tree_id>", "print only tree with the given id (string or number)"),
 	NULL
 };
 
@@ -467,11 +468,7 @@ static int cmd_inspect_tree_stats(const struct cmd_struct *cmd,
 			unit_mode = UNITS_RAW;
 			break;
 		case 't':
-			tree_id = arg_strtou64(optarg);
-			if (!tree_id) {
-				error("unrecognized tree id: %s", optarg);
-				exit(1);
-			}
+			tree_id = parse_tree_id(optarg);
 			break;
 		default:
 			usage_unknown_option(cmd, argv);