Skip to content

Commit 4934fd0

Browse files
committed
Fix unit test for scaling
Signed-off-by: Omer Aplatony <[email protected]>
1 parent 56f8d4a commit 4934fd0

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

pkg/scalers/liiklus_scaler.go

+1-8
Original file line numberDiff line numberDiff line change
@@ -162,13 +162,6 @@ func parseLiiklusMetadata(config *scalersconfig.ScalerConfig) (*liiklusMetadata,
162162
if err := config.TypedConfig(meta); err != nil {
163163
return nil, fmt.Errorf("error parsing liiklus metadata: %w", err)
164164
}
165-
switch {
166-
case meta.Topic == "":
167-
return nil, ErrLiiklusNoTopic
168-
case meta.Address == "":
169-
return nil, ErrLiiklusNoAddress
170-
case meta.Group == "":
171-
return nil, ErrLiiklusNoGroup
172-
}
165+
meta.triggerIndex = config.TriggerIndex
173166
return meta, nil
174167
}

pkg/scalers/liiklus_scaler_test.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -228,11 +228,10 @@ func TestLiiklusScalerGetMetricsBehavior(t *testing.T) {
228228
func TestLiiklusGetMetricSpecForScaling(t *testing.T) {
229229
for _, testData := range liiklusMetricIdentifiers {
230230
t.Run(testData.name, func(t *testing.T) {
231-
meta, err := parseLiiklusMetadata(&scalersconfig.ScalerConfig{TriggerMetadata: testData.metadataTestData.metadata})
231+
meta, err := parseLiiklusMetadata(&scalersconfig.ScalerConfig{TriggerMetadata: testData.metadataTestData.metadata, TriggerIndex: testData.triggerIndex})
232232
if err != nil {
233233
t.Fatal("Could not parse metadata:", err)
234234
}
235-
meta.triggerIndex = testData.triggerIndex
236235
mockLiiklusScaler := liiklusScaler{"", meta, nil, nil, logr.Discard()}
237236
metricSpec := mockLiiklusScaler.GetMetricSpecForScaling(context.Background())
238237
if metricSpec[0].External.Metric.Name != testData.name {

0 commit comments

Comments
 (0)