Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Follow Label and Annotation Recommendations #585

Open
kadel opened this issue Feb 5, 2018 · 4 comments
Open

Follow Label and Annotation Recommendations #585

kadel opened this issue Feb 5, 2018 · 4 comments

Comments

@kadel
Copy link
Member

kadel commented Feb 5, 2018

https://docs.google.com/document/d/1EVy0wRJRm5nogkHl38fNKbFrhERmSL_CLNE4cxcsc_M/edit#

It would be nice if kedge uses recommendations from that document, at least for name and version (app.kubernetes.io/name, app.kubernetes.io/version)

Right now we use app and appversion, I propose chenging appversion to app.kubernetes.io/version , keeping app as it is and adding app.kubernetes.io/name that will have same value as app. (We are keeping app labels because OpenShift uses it to group objects in web console)

@kadel
Copy link
Member Author

kadel commented Feb 5, 2018

we could also add app.kubernetes.io/deploy-manager: kedge as a label

@cdrage
Copy link
Collaborator

cdrage commented Feb 7, 2018

This is as simple as adding to Kedge application labels on generation / creation, correct?

For example:

metadata:
  annotations:
    appversion: 0.8.1
  creationTimestamp: null
  labels:
    app: httpd
    app.kubernetes.io/name: httpd
    app.kubernetes.io/version: 0.0.1
  name: httpd

@surajnarwade
Copy link
Collaborator

@cdrage @kadel , what's the status on community acceptance of labels/annotations proposal ?

@surajnarwade
Copy link
Collaborator

Some queries:

  • Consider wordpress examples

  • if I added these labels, it will be something like:

for wordpress.yml :

metadata:
  creationTimestamp: null
  labels:
    app: wordpress
    app.kubernetes.io/name: wordpress
  name: wordpress

For mariadb :

metadata:
  creationTimestamp: null
  labels:
    app: database
    app.kubernetes.io/name: database
  name: database
  • It indicates, wordpress & mariadb both are different applications but it should be like, mariadb is component of wordpress.

  • @cdrage @kadel @containscafeine thoughts? (I might be completely wrong here)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants