-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kedro viz --load-file
to run from any directory without requiring a Kedro project
#2206
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
kedro viz --load-file
checking for kedro project configurations
kedro viz --load-file
checking for kedro project configurationskedro viz --load-file
to run from any directory without requiring a Kedro project
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @rashidakanchwala!
"red", | ||
) | ||
return | ||
kedro_project_path = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey I'm thinking maybe this kedro_project_path
does not need to be defined outside the if-else statement if it is only used within the else block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is needed later, it is passed to run_server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally and its working as described in the ticket, thanks @rashidakanchwala
Hi @rashidakanchwala , The PR looks good. Something not related to the ticket but if possible, can we update the docs here and here with the directory structure that is needed to run viz when the user does Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a doc comment but the PR works well... Thank you @rashidakanchwala
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Description
This PR fixes #2045.
Previously,
kedro viz --load-file
checked if the command was run from within a Kedro project directory, which is not required. The fix ensures thatkedro viz --load-file
can run from anywhere as long as it has the correct path the API data directory .The key behavior is now as follows:
FileNotFoundError: [Errno 2] No such file or directory: '/path/to/xyz/api/main'
kedro viz --load-file
runs successfully using the API JSON data.Development notes
QA notes
Checklist
RELEASE.md
file