Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the form whitelist and blacklist case-insensitive #237

Closed
luckyrat opened this issue Jul 1, 2019 · 1 comment
Closed

Make the form whitelist and blacklist case-insensitive #237

luckyrat opened this issue Jul 1, 2019 · 1 comment
Milestone

Comments

@luckyrat
Copy link
Member

luckyrat commented Jul 1, 2019

In most situations it makes sense for the strings used to decide if a form should be whitelisted or blacklisted to be case-insensitive. Since some existing user configurations could depend upon the current case-sensitivity, we need to offer a general and site-specific opt-out from the new behaviour.

Implement by adding a new default true site-specific setting to the config structure and settings page - "Ignore case". Then conditionally apply toLowerCase() on all the comparisons in ConfigManager.isFormInteresting()

I'm assigning to myself due to ongoing refactoring that could impact this work but won't be implementing it immediately so I can re-assign if anyone else particularly wants to implement it urgently.

@luckyrat luckyrat self-assigned this Jul 1, 2019
@levicki
Copy link

levicki commented Jul 9, 2019

If I may suggest, it might be better to allow regex in those strings and let users express desired case-sensitivity through regex as suggested in issue #67.

@luckyrat luckyrat removed their assignment Oct 7, 2020
@luckyrat luckyrat added this to the 3.6 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants