Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's possible to include GNU Make in the docker images? #145

Open
reinielherrera opened this issue Jun 18, 2020 · 6 comments
Open

It's possible to include GNU Make in the docker images? #145

reinielherrera opened this issue Jun 18, 2020 · 6 comments

Comments

@reinielherrera
Copy link

Make is shipped with almost every linux distributions, so would be really great if we can use it here

@reinielherrera reinielherrera changed the title Is possible to include make into the OS It is possible to include GNU Make into the OS? Jun 18, 2020
@reinielherrera reinielherrera changed the title It is possible to include GNU Make into the OS? Is it possible to include GNU Make into the OS? Jun 18, 2020
@reinielherrera reinielherrera changed the title Is it possible to include GNU Make into the OS? It's possible to include GNU Make into the OS? Jun 18, 2020
@reinielherrera reinielherrera changed the title It's possible to include GNU Make into the OS? It's possible to include GNU Make in the docker images? Jun 18, 2020
@keeganwitt
Copy link
Owner

keeganwitt commented Jun 18, 2020

Would you mind describing your use case a bit? I ask this anytime someone asks for a new package so we don't end up with a giant image and have good rationale around any additions.

@reinielherrera
Copy link
Author

reinielherrera commented Jun 18, 2020

Thanks for replying, the idea would be use GNU Make like a layer of abstraction and standardization. I've used this tool in almost every project i've working on, and provides pretty good results in the terms mentioned before, also in our line of work is something widely know so people wont get stuck when working on the project for the first time.
Is a pretty small package (https://packages.debian.org/stretch/make), maybe would be a good asset to add.
We can ask around to see if is widely used or not...

Thanks for your consideration

@keeganwitt
Copy link
Owner

Yea, I wasn't concerned about the size of any particular one package ask, just more to make sure we make sane choices so we don't end up with dozens of little packages over time.

Just to make sure I understand your use case, you use Make to invoke Gradle to provide a standard set of Make tasks so your users didn't have to be aware of whether it's Gradle or some other build system underneath?

@reinielherrera
Copy link
Author

Yes, I have been using the Make commands when I have programmed with Maven, Gradle and basically any other tool, in this way I guarantee that all projects keep the same ways of execution

@keeganwitt
Copy link
Owner

I'm still thinking about where the line should be drawn. One could imagine requests for similar use cases, but with Bazel, Scons, Ant, Ninja, Pants, Buck, or other tools I'm not thinking of rather than Make. This request doesn't seem completely unreasonable, but it also doesn't seem appropriate to include every possible tool. And of course it's possible low level tools like Make might require other commands for their execution that are also not currently installed (jq, etc).

This use case kind of reminds me of a talk I saw about Netflix's Newt tool, which configures Docker and runs whatever image and command is appropriate for the language being built. It makes me wonder if it'd work equally well to have the wrapper run outside the context of the image containing the build tool (though I'm not sure how your environments are configured).

@keeganwitt
Copy link
Owner

Would it work for your use case to use this image as a base image? Or run Make outside the context of Docker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants