Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should in-group overleverage be prevented? #45

Open
eth-r opened this issue Feb 6, 2020 · 0 comments
Open

Should in-group overleverage be prevented? #45

eth-r opened this issue Feb 6, 2020 · 0 comments

Comments

@eth-r
Copy link
Contributor

eth-r commented Feb 6, 2020

Currently selectGroup(groupSize) in SortitionPool picks groupSize eligible members without regard for how many times an operator is represented in the group. This means that it is possible, although quite unlikely, for an operator to become overleveraged by being represented in the group more times than their staker weight is. If this happens, it violates the guarantee that each group has groupSize * minimumStake KEEP at stake against misbehavior.

This could be prevented by similar methods as would be used to implement BondedSortitionPool.selectGroup, by tracking each member's number of duplicates and skipping those that have reached their limit. However, it would make group selection slightly more expensive, even if a bloom filter is used to short-circuit checks on obviously non-duplicate operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant