Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Much of Deposit state can be immutable #605

Open
wjmelements opened this issue May 5, 2020 · 3 comments
Open

Much of Deposit state can be immutable #605

wjmelements opened this issue May 5, 2020 · 3 comments
Labels
Milestone

Comments

@wjmelements
Copy link

Currently a lot of state is written via SSTORE. It would be much cheaper to use PUSH. If you updated to the latest solidity you would be able to use immutable variables, which are written into code instead of in storage. This would substantially reduce the gas used to create a deposit or to read its state.

@mhluongo
Copy link
Member

mhluongo commented May 5, 2020

We'd have to upgrade Solidity 6 days before launch. Too risky for my tastes, but flagging this for v2.

Keep these coming! 😍

@mhluongo mhluongo added this to the Post-mainnet milestone May 5, 2020
@wjmelements
Copy link
Author

With the shutdown, will this make it into the next version?

@mhluongo
Copy link
Member

mhluongo commented May 19, 2020

With the shutdown, will this make it into the next version?

Highly unlikely. If it didn't require a Solidity upgrade, touching the whole codebase, it would still be a stretch. I'll keep it in mind if there's an opportunity though.

@mhluongo mhluongo added the tbtc label May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants