Skip to content

Commit 97c263a

Browse files
authored
fix: dbsecretsmanager generates a bunch of logs (#5426)
1 parent 8fa45ae commit 97c263a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

keep/secretmanager/dbsecretmanager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ def read_secret(self, secret_name: str, is_json: bool = False) -> str | dict:
2626
if is_json:
2727
return json.loads(secret_model.value)
2828
return secret_model.value
29-
else:
30-
raise KeyError(f"Secret {secret_name} not found")
3129
except Exception as e:
3230
self.logger.error(
3331
"Failed to read secret",
3432
extra={"error": str(e)},
3533
)
3634
raise
35+
if not secret_model:
36+
raise KeyError(f"Secret {secret_name} not found")
3737

3838

3939
def write_secret(self, secret_name: str, secret_value: str) -> None:

0 commit comments

Comments
 (0)