Skip to content

Commit f64a25a

Browse files
Rename temporary tables to backups instead of dropping them
Temporary tables are renamed to backups to preserve data for potential future use. Comments are added to indicate eventual removal steps if these tables are no longer needed. This change ensures data safety during the interim period.
1 parent 9ee70c7 commit f64a25a

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

keep/api/models/db/migrations/versions/2025-03-07-17-49_aaec81b991bd.py

+13-4
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,19 @@ def upgrade():
204204

205205
transfer_data()
206206

207-
op.drop_table("topologyservicedependency_tmp")
208-
op.drop_table("topologyserviceapplication_tmp")
209-
op.drop_table("topologyapplication_tmp")
210-
op.drop_table("topologyservice_tmp")
207+
# Let's do not drop this as backup for a while
208+
209+
op.rename_table('topologyapplication_tmp', 'topologyapplication_backup')
210+
op.rename_table('topologyservice_tmp', 'topologyservice_backup')
211+
op.rename_table('topologyserviceapplication_tmp', 'topologyserviceapplication_backup')
212+
op.rename_table('topologyservicedependency_tmp', 'topologyservicedependency_backup')
213+
214+
# But after some time we will need to execute this:
215+
216+
# op.drop_table("topologyservicedependency_backup")
217+
# op.drop_table("topologyserviceapplication_backup")
218+
# op.drop_table("topologyapplication_backup")
219+
# op.drop_table("topologyservice_backup")
211220

212221

213222
def downgrade():

0 commit comments

Comments
 (0)