Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add incident severity change feature #3292

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

VladimirFilonov
Copy link
Contributor

Introduces functionality to update incident severity via UI and API. Refactors severity handling logic to allow user-forced severity values and persists this flag in the database. Includes related UI enhancements such as a severity selector and badge updates.

Closes #3231

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 6:29am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. API API related issues Feature A new feature UI User interface related issues labels Feb 3, 2025
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works nice! But the toggle is in some odd position, without the title like other items on the incident page
Screenshot 2025-02-04 at 11 18 11

Introduces functionality to update incident severity via UI and API. Refactors severity handling logic to allow user-forced severity values and persists this flag in the database. Includes related UI enhancements such as a severity selector and badge updates.
Move `IncidentChangeSeveritySelect` from `incident-header` to `incident-overview` for improved logical grouping and context alignment. This enhances code readability and ensures the severity selector is displayed consistently alongside related information.
@VladimirFilonov VladimirFilonov force-pushed the fix/3231-bug-incident-severity-is-not-editable branch from 6ed34e4 to 9a18697 Compare February 4, 2025 09:24
@VladimirFilonov
Copy link
Contributor Author

@Matvey-Kuk moved =)

image

This commit removes an unnecessary debug `console.log` statement from the `validate` function in `provider-form.tsx`. Cleaning up debug code ensures better readability and maintains a cleaner codebase.
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 23.40426% with 36 lines in your changes missing coverage. Please review.

Project coverage is 46.56%. Comparing base (1168628) to head (7377205).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/db.py 5.55% 17 Missing ⚠️
keep/api/bl/incidents_bl.py 22.22% 14 Missing ⚠️
keep/api/routes/incidents.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3292      +/-   ##
==========================================
- Coverage   46.59%   46.56%   -0.04%     
==========================================
  Files         152      152              
  Lines       14089    14160      +71     
==========================================
+ Hits         6565     6593      +28     
- Misses       7524     7567      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues Feature A new feature size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Incident severity is not editable
4 participants