Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Correlation data in the UI is abnormal #3724

Open
Nctllnty opened this issue Feb 27, 2025 · 2 comments
Open

[🐛 Bug]: Correlation data in the UI is abnormal #3724

Nctllnty opened this issue Feb 27, 2025 · 2 comments
Labels
Bug Something isn't working UI User interface related issues

Comments

@Nctllnty
Copy link

Nctllnty commented Feb 27, 2025

keep version
Version: latest | Build: f76417
Describe the bug
I found that the correlation engine UI had an abnormal display problem. The results displayed on the front end were inconsistent with the data returned by the back end.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'correlation engine'
  2. See error

Screenshots
Image
Image
Image

Api response

{
        “id”: “1357b5f2-0180-4cd7-a4db-b8ad1a0499b6",
        “timeframe”: 86400,
        “require_approve”: false,
        “timeunit”: “hours”,
        “resolve_on”: “all_resolved”,
        “created_by”: “keep”,
        “create_on”: “all”,
        “definition_cel”: “cluster.contains(\“gateway\“) && cluster.contains(\“oci\“) && !((severity in [\“warning\“, \“info\“]))“,
        “creation_time”: “2025-02-26T05:47:17",
        “is_deleted”: false,
        “incident_name_template”: “网关服务美洲地区服务可用性降级“,
        “tenant_id”: “keep”,
        “updated_by”: “keep”,
        “group_description”: “”,
        “update_time”: “2025-02-26T06:32:45",
        “definition”: {
            “sql”: “(cluster like :cluster_1 and cluster like :cluster_2 and NOT ((severity in (:severity_1, :severity_2))))“,
            “params”: {
                “cluster_1": “%gateway%“,
                “cluster_2”: “%oci%“,
                “severity_1”: “warning”,
                “severity_2”: “info”
            }
        },
        “grouping_criteria”: [],
        “name”: “网关服务美洲地区服务可用性降级“,
        “item_description”: null,
        “distribution”: [],
        “incidents”: 0
    },
    {
        “id”: “699c16b6-4d45-4e9a-a480-eb66b28dc8c7”,
        “timeframe”: 86400,
        “require_approve”: false,
        “timeunit”: “hours”,
        “resolve_on”: “all_resolved”,
        “created_by”: “keep”,
        “create_on”: “all”,
        “definition_cel”: “(source == \“Incident-form\“)”,
        “creation_time”: “2025-02-26T05:54:27”,
        “is_deleted”: false,
        “incident_name_template”: “{{ alert.name }}“,
        “tenant_id”: “keep”,
        “updated_by”: null,
        “group_description”: “”,
        “update_time”: null,
        “definition”: {
            “sql”: “((source = :source_1))“,
            “params”: {
                “source_1": “Incident-form”
            }
        },
        “grouping_criteria”: [
            “service”
        ],
        “name”: “故障登记表故障事件自动同步“,
        “item_description”: null,
        “distribution”: [],
        “incidents”: 0
    },
    {
        “id”: “6a7f5b86-5b7c-4beb-84b2-9ab41d1075ac”,
        “timeframe”: 86400,
        “require_approve”: false,
        “timeunit”: “hours”,
        “resolve_on”: “all_resolved”,
        “created_by”: “keep”,
        “create_on”: “all”,
        “definition_cel”: “cluster.contains(\“gateway\“) && cluster.contains(\“gcp\“) && !((severity in [\“warning\“, \“info\“]))“,
        “creation_time”: “2025-02-26T05:43:46",
        “is_deleted”: false,
        “incident_name_template”: “网关服务美洲地区服务可用性降级“,
        “tenant_id”: “keep”,
        “updated_by”: “keep”,
        “group_description”: “”,
        “update_time”: “2025-02-26T06:32:54",
        “definition”: {
            “sql”: “(cluster like :cluster_1 and cluster like :cluster_2 and NOT ((severity in (:severity_1, :severity_2))))“,
            “params”: {
                “cluster_1": “%gateway%“,
                “cluster_2”: “%gcp%“,
                “severity_1”: “warning”,
                “severity_2”: “info”
            }
        },
        “grouping_criteria”: [
            “cluster”
        ],
        “name”: “网关服务美洲地区服务可用性降级“,
        “item_description”: null,
        “distribution”: [],
        “incidents”: 0
    },
    {
        “id”: “dc2cb3c6-21e6-4507-8aaa-0cb5fe0e1590”,
        “timeframe”: 86400,
        “require_approve”: false,
        “timeunit”: “hours”,
        “resolve_on”: “all_resolved”,
        “created_by”: “keep”,
        “create_on”: “any”,
        “definition_cel”: “cluster.contains(\“gateway\“) && cluster.contains(\“linode\“) && !((severity in [\“warning\“, \“info\“]))“,
        “creation_time”: “2025-02-26T06:11:16",
        “is_deleted”: false,
        “incident_name_template”: “网关服务亚洲地区服务可用性降级“,
        “tenant_id”: “keep”,
        “updated_by”: “keep”,
        “group_description”: “”,
        “update_time”: “2025-02-26T06:32:33",
        “definition”: {
            “sql”: “(cluster like :cluster_1 and cluster like :cluster_2 and NOT ((severity in (:severity_1, :severity_2))))“,
            “params”: {
                “cluster_1": “%gateway%“,
                “cluster_2”: “%linode%“,
                “severity_1”: “warning”,
                “severity_2”: “info”
            }
        },
        “grouping_criteria”: [
            “cluster”
        ],
        “name”: “网关服务亚洲地区服务可用性降级“,
        “item_description”: null,
        “distribution”: {
            “linode-sin2-gateway-2”: {
                “2025-02-26 06:31": 1
            }
        },
        “incidents”: 1
    }
Copy link

dosubot bot commented Feb 27, 2025

The discrepancy between the UI display and the back-end data in the Keep platform might be due to the UI incorrectly using a success notification regardless of the actual merge result from the backend. The backend may skip incidents during the merge process and return a status message indicating this, but the UI doesn't properly handle these non-success cases. To address this, the UI should replace the success notification with an informational notification that displays the actual result message from the backend response [1].

Additionally, ensure that the UI is correctly synchronizing with the back-end data. The Keep platform uses form handling, API requests, and state management to synchronize data. When a user submits the correlation form, the data is sent to the back-end, and the UI is updated based on the response [2][3]. If there are validation errors, such as incorrect use of HTML elements, these should be addressed to ensure proper form functionality and accessibility [4].

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

@dosubot dosubot bot added Bug Something isn't working UI User interface related issues labels Feb 27, 2025
@Nctllnty
Copy link
Author

Nctllnty commented Mar 4, 2025

I found that if I use the “not in” condition, an error will inevitably occur on the front-end page.」

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working UI User interface related issues
Projects
None yet
Development

No branches or pull requests

1 participant