Skip to content

Log node/ec2 instance name on nodes.drainNode error #115

@karimlakhani

Description

@karimlakhani

Is this a BUG REPORT or FEATURE REQUEST?:
feature request
What happened:
error logging does not include the node name / ec2 instance id
What you expected to happen:
when logging the error, include the node name / ec2 instance id
How to reproduce it (as minimally and precisely as possible):
you need the drainNode to fail for some reason other than if err.Error() == "command execution timed out" {
Anything else we need to know?:

Environment:
ALl

  • Kubernetes version:
    All
kubectl version -o yaml

Other debugging information (if applicable):
this is the code https://github.com/keikoproj/lifecycle-manager/blob/7084174977de0a30f20fa2ba8e545383f4067575/pkg/service/nodes.go#LL67C1-L68C1

  • relevant logs:
kubectl logs <lifecycle-manager-pod>

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions