Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MusicBrainz provider #49

Open
Tracked by #5
kellnerd opened this issue Jun 28, 2024 · 1 comment
Open
Tracked by #5

MusicBrainz provider #49

kellnerd opened this issue Jun 28, 2024 · 1 comment
Assignees
Labels
feature New feature or request provider Metadata provider

Comments

@kellnerd
Copy link
Owner

kellnerd commented Jun 28, 2024

ID lookups are already working in my development branch, GTIN lookups still have to be implemented.

@kellnerd kellnerd mentioned this issue Jun 28, 2024
17 tasks
@kellnerd kellnerd added feature New feature or request provider Metadata provider labels Jun 28, 2024
@kellnerd kellnerd self-assigned this Jun 28, 2024
@kellnerd kellnerd changed the title MusicBrainz MusicBrainz provider Jun 28, 2024
@phw
Copy link
Collaborator

phw commented Jul 1, 2024

From discussion at #15:

Is the MB provider also considered the solution for finding existing MB releases, so the user can be notified that a release already exists?

That's the idea, at least for the GTIN this should work without additional effort.
I haven't yet decided whether I want to also do MB lookups for the external links of the other providers like a-tisket does it.
The more providers are used for the combined lookup, the more potentially useless requests would be sent to the MB API. Especially since most of the time people will probably import a specific release which is missing on MB rather than trying to import a release which may already exist on MB.

I nevertheless think it would be good to do this. Maybe add it behind an option if it should not run by default. Or at least do the lookup for the URL given. But digital releases are frequently added without GTIN. For one they are optional on e.g. Bandcamp. And even the services having it mandatory don't expose them to the user directly.

I frequently add releases from Bandcamp using the importer userscript. That it does lookup potentially existing releases by URL is tremendously useful.

Also I think Harmony should not just show existing MB releases and warn about them, but also allow to jump to the post submission page for each release MBID to allow the user to submit ISRCs, cover art or any other data that might be added in the future (e.g. artist links, adding missing service links to releases etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request provider Metadata provider
Projects
None yet
Development

No branches or pull requests

2 participants