Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concat() test using ArrayProxy #485

Open
Turbo87 opened this issue Jun 22, 2018 · 2 comments
Open

Add concat() test using ArrayProxy #485

Turbo87 opened this issue Jun 22, 2018 · 2 comments

Comments

@Turbo87
Copy link
Collaborator

Turbo87 commented Jun 22, 2018

The Ember.Array interface does not define a concat() method, but the concat() macro seems to use it as if it exists. We might have an issue here and we should at least add a test to make sure whether it works or not.

@kellyselden
Copy link
Owner

Agreed. Anyone watching is free to help. @Turbo87 Can now help review and merge.

@baljeet03
Copy link

@Turbo87 I would like to do that. I had a little doubt regarding the test case though. Should I create a Ember.ArrayProxy object and convert it to array and test it or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants