"Failed to extract" error when icon is not in located in the appdir root

[DetachHead]

thanks for fixing #41. all my appimages (mostly) work now except one:

https://github.com/DetachHead/rebased/releases/download/0.1.6/Rebased-x86_64.AppImage

admittedly this is the one appimage i maintain myself, so i'm not sure how common this pattern is. the icon file is not located within the root directory, but rather in /usr/bin:

[Desktop Entry]
Name=Rebased
Exec=AppRun
Icon=/usr/bin/idea
Type=Application
Categories=Development;IDE;
Terminal=false
StartupWMClass=jetbrains-rebased
StartupNotify=true

[kem-a]

You don't have icon in root dir:

In your desktop entry Icon points to bin? or you placed icon there? Anyway, correct icon location should be at usr/share/icons/hicolor

[Samueru-sama]

https://github.com/AppImage/AppImageSpec/blob/master/draft.md#contents-of-the-image

• MUST contain a .DirIcon file as per the AppDir specification which SHOULD be a 256x256 PNG file.

[DetachHead]

hmm looks like this is appimagetool's fault. it seems to generate a broken .DirIcon if the icon referenced in the .desktop file isn't in the AppDir root. but from what i've read there doesn't seem to be any rule against doing that?

regardless i'll just update my appimage to be consistent with all the others. though it's annoying how there seems to be so many ways to screw up building an appimage yet appimagetool doesn't seem to warn you about any of them lol

thanks for all your help btw