Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line width sets in terms of rem, not ch #80

Open
huw opened this issue Feb 27, 2024 · 2 comments
Open

Line width sets in terms of rem, not ch #80

huw opened this issue Feb 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@huw
Copy link

huw commented Feb 27, 2024

Minimal Theme Settings lets me set the normal and long line width. The help text set with the field says:

Number of characters per line (default 40).

But in practice, Minimal Theme Settings actually sets the line width to 40rem, which is the height (roughly) of 40 characters.

If you think this is a problem, I can either submit a PR to:

  1. Correct the help text
  2. Change the units to ch, which are widely supported (98.45%) and agree with the help text

I think option 2 is more suitable, since most discussions of readability of text refer to number of characters per line. Please let me know if I'd also have to PR the theme itself.

@huw huw added the bug Something isn't working label Feb 27, 2024
@kepano
Copy link
Owner

kepano commented Mar 5, 2024

I don't disagree, but the challenge with changing the unit is that all existing settings will be broken when people update the plugin.

@huw
Copy link
Author

huw commented Mar 7, 2024

I wonder if the solution would be to add units to the settings (either directly in the text field or with a split input dropdown). I can imagine that being useful for other units (line height, font size). Anyway, I’ve worked around it locally by just overriding the stylesheet myself so this isn’t major for me but I could try and PR that if you like :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants