fix(auth): improve token expiry precision and org ID#10
Merged
masnwilliams merged 1 commit intomainfrom Sep 4, 2025
Merged
Conversation
There was a problem hiding this comment.
Performed full review of 556ab5b...9904c2d
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
2 files reviewed | 3 comments | Review on Mesa | Edit Reviewer Settings
rgarcia
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes a bug in the token refresh logic that caused premature token expiry and incorrect organization ID handling.
Why we made these changes
The previous token refresh logic used imprecise, integer-based timestamps for calculating token expiry. This could cause the CLI to assume a token was expired when it was still valid, forcing unnecessary logouts and disrupting user workflows. Additionally, the
organization_idwas not correctly persisted during a refresh, which could lead to context-related errors.What changed?
organization_idis correctly requested and stored during the token refresh flow.Description generated by Mesa. Update settings