Conversation
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 76b837f...4d3c59f
Analysis
Based on the provided analysis, there don't appear to be significant architectural issues with this PR. It seems to be primarily focused on adding documentation for Chrome extension support, following established patterns and conventions in the codebase.
Since the analysis doesn't highlight any potential issues, and the PR appears to be focused on documentation rather than implementation changes, there aren't specific architectural concerns to point out in this case.
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
2 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
…d-browser-extensions
|
whoops, updated on accident, though this was another pr... |
…d-browser-extensions
| kernel extensions download-web-store https://chromewebstore.google.com/detail/shutterfly-address-book-e/lddlpciejomhjehckimopnomegilaocb --to ./downloaded-extension | ||
| ``` | ||
|
|
||
| From here you can upload the extension to Kernel as normal. |
There was a problem hiding this comment.
I think we should continue with the example here and just showcase this code snippet:
kernel extensions upload ./downloaded-extension --dws-extension
browsers/extensions.mdx
Outdated
| If you have a browser running and would like to load an extension into it after the browser session has started, Kernel also allows you to do that via the CLI (or [API](http://localhost:3000/api-reference/browsers/ad-hoc-upload-one-or-more-unpacked-extensions-to-a-running-browser-instance)): | ||
|
|
||
| ```bash CLI | ||
| kernel browsers extensions upload $session_id ./my-extension |
There was a problem hiding this comment.
Instead of $session_id, I would suggest using <session_id> as that matches the formatting for variables to be entered in the CLI docs
| kernel browsers extensions upload $session_id ./my-extension | ||
| ``` | ||
|
|
||
| Note that this will restart the browser process and break any connections to the browser CDP URL. |
There was a problem hiding this comment.
I suggest putting this in a block:
Note that this will restart the browser process and break any connections to the browser CDP URL.
Mesa DescriptionDescriptionAdds docs for custom extension support Implementation Checklist
Testing
Docs
Visual ProofPlease provide a screenshot or video demonstrating that your changes work locally: [Drag and drop your screenshot/video here or use the following format:] Related IssueFixes [Github issue link] [If this corresponds to a fix from another Kernel OSS repo, include this:] Fixes [Link to other repo] [Replace with actual issue link, e.g., Fixes https://github.com/username/repo/issues/123] Additional Notes[Any additional context, concerns, or notes for reviewers] TL;DRThis PR adds documentation for custom browser extension support and updates the pricing page to reflect the feature's availability. Why we made these changesTo support the launch of the custom browser extensions feature, this documentation guides users on how to upload, install, and manage them via the CLI and API. What changed?
Validation
Description generated by Mesa. Update settings |
…d-browser-extensions
dprevoznik
left a comment
dprevoznik
left a comment
There was a problem hiding this comment.
LGTM. Thx for the edits.
rgarcia
deleted the
raf/kernel-262-feature-request-ability-to-add-browser-extensions
branch
4 participants
Description
Adds docs for custom extension support
Implementation Checklist
Testing
mintlify devworks (see installation here)Docs
Visual Proof
Please provide a screenshot or video demonstrating that your changes work locally:
[Drag and drop your screenshot/video here or use the following format:]
]
[
Related Issue
Fixes [Github issue link]
[If this corresponds to a fix from another Kernel OSS repo, include this:]
Fixes [Link to other repo]
[Replace with actual issue link, e.g., Fixes https://github.com/username/repo/issues/123]
Additional Notes
[Any additional context, concerns, or notes for reviewers]
TL;DR
This PR adds documentation for custom browser extension support and updates the pricing page to reflect the feature's availability.
Why we made these changes
To support the launch of the custom browser extensions feature, this documentation guides users on how to upload, install, and manage them.
What changed?
browsers/extensions.mdx, a new documentation page explaining how to use extensions with Kernel browsers.docs.jsonto add the new extensions page to the "Browsers" section in the site navigation.info/pricing.mdxto show "Configurable browser extensions" as an available feature for Pro and Enterprise tiers, removing the "Coming soon" tag.Validation
mintlify dev.Description generated by Mesa. Update settings