fix(macos): add e2fsprogs PATH and don't cache failed image builds

- Makefile: prepend e2fsprogs sbin to PATH for dev-darwin and run-darwin
  targets so mkfs.ext4 is found without requiring shell profile changes
- manager.go: don't cache failed image builds, clean up failed build
  directory to allow retries after fixing the underlying issue

Author: rgarcia

Makefile

@@ -308,7 +308,7 @@ sign-darwin-identity: build-darwin
 # macOS development mode with hot reload (uses vz, no sudo needed)
 dev-darwin: build-embedded $(AIR)
 	@rm -f ./tmp/main
-	$(AIR) -c .air.darwin.toml
+	PATH="/opt/homebrew/opt/e2fsprogs/sbin:$(PATH)" $(AIR) -c .air.darwin.toml
 
 # Run without hot reload (for testing)
 run:
@@ -322,7 +322,7 @@ run-linux: ensure-ch-binaries ensure-caddy-binaries build-embedded build
 	./bin/hypeman
 
 run-darwin: sign-darwin
-	./bin/hypeman
+	PATH="/opt/homebrew/opt/e2fsprogs/sbin:$(PATH)" ./bin/hypeman
 
 # Quick test of vz package compilation
 .PHONY: test-vz-compile

lib/images/manager.go

@@ -113,18 +113,26 @@ func (m *manager) CreateImage(ctx context.Context, req CreateImageRequest) (*Ima
 
 	// Check if we already have this digest (deduplication)
 	if meta, err := readMetadata(m.paths, ref.Repository(), ref.DigestHex()); err == nil {
-		// We have this digest already
-		if meta.Status == StatusReady && ref.Tag() != "" {
-			// Update tag symlink to point to current digest
-			// (handles case where tag moved to new digest)
-			createTagSymlink(m.paths, ref.Repository(), ref.Tag(), ref.DigestHex())
-		}
-		img := meta.toImage()
-		// Add queue position if pending
-		if meta.Status == StatusPending {
-			img.QueuePosition = m.queue.GetPosition(meta.Digest)
+		// Don't cache failed builds - allow retry
+		if meta.Status == StatusFailed {
+			// Clean up the failed build directory so we can retry
+			digestDir := filepath.Join(m.paths.ImagesDir(), ref.Repository(), ref.DigestHex())
+			os.RemoveAll(digestDir)
+			// Fall through to re-queue the build
+		} else {
+			// We have this digest already (ready, pending, pulling, or converting)
+			if meta.Status == StatusReady && ref.Tag() != "" {
+				// Update tag symlink to point to current digest
+				// (handles case where tag moved to new digest)
+				createTagSymlink(m.paths, ref.Repository(), ref.Tag(), ref.DigestHex())
+			}
+			img := meta.toImage()
+			// Add queue position if pending
+			if meta.Status == StatusPending {
+				img.QueuePosition = m.queue.GetPosition(meta.Digest)
+			}
+			return img, nil
 		}
-		return img, nil
 	}
 
 	// Don't have this digest yet, queue the build
@@ -156,15 +164,22 @@ func (m *manager) ImportLocalImage(ctx context.Context, repo, reference, digest
 
 	// Check if we already have this digest (deduplication)
 	if meta, err := readMetadata(m.paths, ref.Repository(), ref.DigestHex()); err == nil {
-		// We have this digest already
-		if meta.Status == StatusReady && ref.Tag() != "" {
-			createTagSymlink(m.paths, ref.Repository(), ref.Tag(), ref.DigestHex())
-		}
-		img := meta.toImage()
-		if meta.Status == StatusPending {
-			img.QueuePosition = m.queue.GetPosition(meta.Digest)
+		// Don't cache failed builds - allow retry
+		if meta.Status == StatusFailed {
+			digestDir := filepath.Join(m.paths.ImagesDir(), ref.Repository(), ref.DigestHex())
+			os.RemoveAll(digestDir)
+			// Fall through to re-queue the build
+		} else {
+			// We have this digest already
+			if meta.Status == StatusReady && ref.Tag() != "" {
+				createTagSymlink(m.paths, ref.Repository(), ref.Tag(), ref.DigestHex())
+			}
+			img := meta.toImage()
+			if meta.Status == StatusPending {
+				img.QueuePosition = m.queue.GetPosition(meta.Digest)
+			}
+			return img, nil
 		}
-		return img, nil
 	}
 
 	// Don't have this digest yet, queue the build