allow downloading in progress recordings

Author: Sayan-

server/cmd/api/api/api.go

@@ -99,17 +99,21 @@ func (s *ApiService) DownloadRecording(ctx context.Context, req oapi.DownloadRec
 		return oapi.DownloadRecording404JSONResponse{NotFoundErrorJSONResponse: oapi.NotFoundErrorJSONResponse{Message: "no recording found"}}, nil
 	}
 
-	if rec.IsRecording(ctx) {
-		log.Warn("attempted to download recording while is still in progress")
-		return oapi.DownloadRecording400JSONResponse{BadRequestErrorJSONResponse: oapi.BadRequestErrorJSONResponse{Message: "recording still in progress, please stop first"}}, nil
-	}
-
 	out, meta, err := rec.Recording(ctx)
 	if err != nil {
 		log.Error("failed to get recording", "err", err)
 		return oapi.DownloadRecording500JSONResponse{InternalErrorJSONResponse: oapi.InternalErrorJSONResponse{Message: "failed to get recording"}}, nil
 	}
 
+	// short-circuit if the recording is still in progress and the file is arbitrary small
+	if rec.IsRecording(ctx) && meta.Size <= 100 {
+		return oapi.DownloadRecording202Response{
+			Headers: oapi.DownloadRecording202ResponseHeaders{
+				RetryAfter: 300,
+			},
+		}, nil
+	}
+
 	log.Info("serving recording file for download", "size", meta.Size)
 	return oapi.DownloadRecording200Videomp4Response{
 		Body:          out,

server/lib/recorder/ffmpeg.go

@@ -188,10 +188,6 @@ func (fr *FFmpegRecorder) IsRecording(ctx context.Context) bool {
 
 // Recording returns the recording file as an io.ReadCloser.
 func (fr *FFmpegRecorder) Recording(ctx context.Context) (io.ReadCloser, *RecordingMetadata, error) {
-	if fr.IsRecording(ctx) {
-		return nil, nil, fmt.Errorf("recording still in progress, please call stop first")
-	}
-
 	file, err := os.Open(fr.outputPath)
 	if err != nil {
 		return nil, nil, fmt.Errorf("failed to open recording file: %w", err)