Capture config registry recommendation outcomes - #187
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 450b408. Configure here.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary
submit_feedbackwith structured bot-detection and config-registry outcome routeswhy
A site-level block identifies missing coverage, but it does not show whether an existing config-registry recommendation failed after an agent used it. The config-registry route connects the observed outcome to the browser session, recommendation evidence, and applied configuration. If an agent changes the recommendation before testing, it uses the general bot-detection route instead so the result is not incorrectly attributed to the original config.
testing
bun test— 453 passedbunx tsc --noEmitKERNEL_CLI_PROD_CLIENT_ID=test-prod KERNEL_CLI_STAGING_CLIENT_ID=test-staging KERNEL_CLI_DEV_CLIENT_ID=test-dev bun run buildbunx prettier --check README.md src/lib/mcp/tools/feedback.ts src/lib/mcp/tools/feedback.test.ts src/lib/mcp/analytics.ts src/lib/mcp/analytics.test.ts package.jsonbun run format:checkstill reports the pre-existingAGENTS.mdformatting warning; all changed files pass Prettier.Note
Medium Risk
Changes the public MCP tool input schema and analytics payload shape agents rely on; validation and redaction reduce privacy risk but mis-routed feedback could affect config-registry prioritization signals.
Overview
Extends
submit_feedbackwith two new routes:bot_detectionfor site pass/challenge/block/degraded outcomes not tied to an unchanged registry recommendation, andconfig_registrywhen a recommendation was applied unchanged and the result should be attributed to that configuration.Agents must supply structured
bot_detection(public registrable domain viatldts, outcome, reproducibility, optional session/browser/proxy metadata) and, for config-registry reports,config_registry(request method, recommendation evidence, exact applied browser and proxy settings). The handler enforces cross-field rules (e.g.browser_session_idrequired for config-registry) and rejects URLs, subdomains, private hosts, andbot_detectionon non-site feedback types.PostHog capture adds
feedback_destination(config_registry_prioritizationvsconfig_registry_quality), a deterministicapplied_config_key, and allow-listed flattened properties. README documents the new routing; existing product/mcp/docs feedback behavior is unchanged.Reviewed by Cursor Bugbot for commit 58c5b15. Bugbot is set up for automated code reviews on this repo. Configure here.