feat(HardwareDetails): add platform card to tabs#710
Merged
Conversation
murilx
force-pushed
the
feat/platforms-card
branch
2 times, most recently
from
1d02243 to
9a2d212
Compare
WilsonNet
reviewed
Dec 23, 2024
| class ParsedFilter(TypedDict): | ||
| field: str | ||
| value: Any # TODO: correctly type this field | ||
| comparison_op: Literal["exact", "in", "gt", "gte", "lt", "lte", "like"] |
WilsonNet
reviewed
Dec 23, 2024
| configStatusCounts={tests.configs} | ||
| diffFilter={diffFilter} | ||
| /> | ||
| <MemoizedPlatformsCard |
Collaborator
There was a problem hiding this comment.
because everything is in the same div, everything is on the same column can you spread the cards between two divs here?
WilsonNet
reviewed
Dec 23, 2024
| configStatusCounts={boots.configs} | ||
| diffFilter={diffFilter} | ||
| /> | ||
| <MemoizedPlatformsCard |
Collaborator
|
filters are missing in the modals |
murilx
force-pushed
the
feat/platforms-card
branch
2 times, most recently
from
3b7e635 to
24f2277
Compare
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
See if you can combine the second with the first commit. You could also split the commits into backend/frontend. The third commit is ok, it's just formatting.
murilx
force-pushed
the
feat/platforms-card
branch
from
24f2277 to
0142686
Compare
MarceloRobert
approved these changes
Dec 24, 2024
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
Worked on my tests, LGTM
- Changed `'` to `"` as it's been used through all the source code - Changed identation in function arguments and boolean expressions
WilsonNet
force-pushed
the
feat/platforms-card
branch
from
0142686 to
92abc06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #678
How to test
Example of Hardware Details with more than one platform (localhost)
Visual Reference