Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: quantum utils docstrings and tests #102

Closed
2 of 9 tasks
aarontrowbridge opened this issue May 29, 2024 · 4 comments
Closed
2 of 9 tasks

[Feature]: quantum utils docstrings and tests #102

aarontrowbridge opened this issue May 29, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers unitaryhack issue Issue is bountied for unitaryhack hackathon

Comments

@aarontrowbridge
Copy link
Collaborator

Feature Description

We are looking for someone to write docstrings and tests for all of the functions in the file src/quantum_utils.jl.

Some docstrings are in place, but a lot are not. The extant ones, if necessary, should be expanded to include a description of the function and the arguments, in line with the blue style guidelines.

Implementation details

Importance

1 (lowest)

What does this feature affect?

  • quantum system construction
  • problem setup
  • problem solution
  • problem performance
  • solution analysis
  • plotting
  • documentation
  • tests
  • other (please specify below)

Other information

No response

@aarontrowbridge aarontrowbridge added enhancement New feature or request good first issue Good for newcomers labels May 29, 2024
@Fe-r-oz
Copy link
Contributor

Fe-r-oz commented May 29, 2024

Sounds interesting! I would like to work on this.

@andgoldschmidt
Copy link
Member

@Fe-r-oz It's yours to pursue! Check the contribution guide for some notes regarding testing.

Feedback on the naming and interpretability of the utilities is appreciated at this time. We also welcome suggestions for missing utilities, filling gaps or improving what has currently been made available.

@aarontrowbridge aarontrowbridge added the unitaryhack issue Issue is bountied for unitaryhack hackathon label May 30, 2024
@Fe-r-oz
Copy link
Contributor

Fe-r-oz commented Jun 4, 2024

Hi, @aarontrowbridge, Kindly please review the PR #111. All the tests 5 passed

Since it has both documentation and testing, it's a little long. I tried best to follow the best practices from the guide this guide.. If there is something wrong, please let me know in the review.

I also included comments to better expain each and every test. I hope the PR satisfies the requirements. Thank you.

@Fe-r-oz
Copy link
Contributor

Fe-r-oz commented Jun 8, 2024

Hi, Please close this issue as it's resolved! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers unitaryhack issue Issue is bountied for unitaryhack hackathon
Projects
None yet
Development

No branches or pull requests

3 participants