Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create optics.jl #110

Closed
wants to merge 3 commits into from
Closed

Conversation

maxwell04-wq
Copy link
Contributor

Fixes #85.

Addition: A \QuantumCollocation\QuantumCollocation.jl-main\src\quantum_system_templates\optics.jl file has been added for creating QuantumSystem objects using the QuantumOptics library. This is a basic implementation and documentation and tests will be added once the Hamiltonian implementation is verified.

@maxwell04-wq
Copy link
Contributor Author

@aarontrowbridge I have implemented only the required functions using the Jaynes-Cummings model for H-drift and H_drivers. Can you please review the base implementation so that I can make the requisite changes before moving forward with the PR?

@aarontrowbridge
Copy link
Collaborator

So I think we need to discuss what to do with this issue, as I seem to have ambiguously defined this problem. We are not looking for the creation of a specific system but rather a simple method for creating QuantumSystems (which require passing a drift Hamiltonian and vector of drive Hamiltonians) from quantum objects created with other packages. What you have done does not accomplish this, and, this moreover wouldn't even work in its current state. Did you ever test it? It also seems like it was ripped directly from the Jaynes-Cummings example page of the QuantumOptics.jl docs.

@aarontrowbridge
Copy link
Collaborator

I'm closing this pull request as we need to start from square one I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: interface with QuantumOptics.jl
2 participants